Add timestamp to simulate logs & blob gas & remove total difficulty#9406
Merged
Add timestamp to simulate logs & blob gas & remove total difficulty#9406
Conversation
LukaszRozmej
reviewed
Oct 3, 2025
Comment on lines
-124
to
-125
| [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)] | ||
| public UInt256? TotalDifficulty { get; set; } |
Member
There was a problem hiding this comment.
I say leave it for AuRa and Clique
If we really want we can remove (by setting null) in past blocks if we are post-merge. But that probably will still fail the test.
But the test is shit as TD is valid property for pre-merge blocks and Geth just yolo removed it.
Contributor
Author
There was a problem hiding this comment.
I would remove it as well. Rn now we store it in the db for no apparent reason
Do we use clique anywhere? I think at this point we can remove it with ethash. And we probably should
Member
There was a problem hiding this comment.
- Japan Open Chain still uses Clique and is supported.
- We still have some Clique and AuRa uses, but they are not officially supported networks.
- We still need AuRa and Ethash for full syncing networks that were merged later (mainnet, gnosis). We could probably rip out large part from them, but can't remove them completely. But it is an effort.
Thus lets not do sudden moves without proper plan and scope.
LukaszRozmej
reviewed
Oct 3, 2025
LukaszRozmej
approved these changes
Oct 7, 2025
flcl42
pushed a commit
that referenced
this pull request
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
There is a bug in geth that sets timstamps to zero in eth simulate
For context: ethereum/go-ethereum#32831
Types of changes
What types of changes does your code introduce?
Testing