-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix(taro-plugin-generator): vite runner 配置 #17929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough本次变更主要针对 Taro 项目的 ES5 生成器插件,增加了对 Vite 编译器的支持。更新内容包括根据不同编译器类型分别修改配置文件、错误处理逻辑和依赖模板,并简化了 package.json 中 browserslist 字段的结构。 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant es5Generator
participant configUpdater
User->>es5Generator: 执行 es5Generator(ctx)
es5Generator->>es5Generator: 获取 compilerType
es5Generator->>configUpdater: updateConfig({ ctx, compilerType })
configUpdater->>configUpdater: 根据 compilerType 修改配置
configUpdater-->>es5Generator: 返回
es5Generator->>es5Generator: 更新 browserslist 配置
es5Generator-->>User: 生成完成
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings
packages/taro-cli/templates/default/package.json.tmpl (1)
packages/taro-plugin-generator/src/generators/es5/index.ts (1)
🧬 Code Graph Analysis (1)packages/taro-plugin-generator/src/generators/es5/config.ts (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (10)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
c7c8c99
to
22cdcb5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17929 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 417 417
Lines 21693 21693
Branches 5356 5354 -2
=======================================
Hits 11928 11928
- Misses 8083 8091 +8
+ Partials 1682 1674 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
这个 PR 做了什么? (简要描述所做更改)
编译为es5 vite runner 配置错误
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit
新功能
重构