"Go analysis already performed, skipping"

[astrelsky]

Describe the bug
After patching reflection data in an obfuscated go binary, as 90% of them are, and trying to run analysis again, nothing happens and the aforementioned message is in the log.

To Reproduce
Steps to reproduce the behavior:

1. Run analysis
2. Wait
3. Save
4. Patch the go version metadata to be non garbage.
5. Try to run go symbol analysis again.
6. See nothing happen.

Expected behavior
It should run analysis, preferably the first time but I'll take what I can get.

Environment (please complete the following information):

• Ghidra Version: 12.1_DEV

Additional context
I've removed the TransientProgramProperties and it is still refusing to run the analysis to fixup the duff functions.

[astrelsky]

Defeating Ghidra's go analysis is trivial, just edit one byte, but this is typically what is used for go obfuscation.

https://github.com/burrowers/garble