Fix nerfcapture2nerf.py to allow to run it without depth info#1533
Open
Konstantysz wants to merge 3 commits intoNVlabs:masterfrom
Open
Fix nerfcapture2nerf.py to allow to run it without depth info#1533Konstantysz wants to merge 3 commits intoNVlabs:masterfrom
Konstantysz wants to merge 3 commits intoNVlabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written in
pybindissue, when passingNoneto C++ function,numpyactually passesNaN. This leads to access violation as(const float*)depth_buf.ptrinvoid set_image(int frame_idx, pybind11::array_t<float> img, pybind11::array_t<float> depth_img, float depth_scale)is notnullptr, while being empty.Other solution would be to make
void set_image(int frame_idx, pybind11::array_t<float> img, pybind11::array_t<float> depth_img, float depth_scale)argumentdepth_imgtypestd::optional<pybind11::array_t<float>>. This would lead to no code duplication, however requires C++17.