Skip to content

Conversation

@t0mmylam
Copy link
Collaborator

Summary

Restructures the Skyhook CLI to follow the Kueue-style cmd/cli/app/ pattern and consolidates duplicate lifecycle commands into a single file with shared implementation.

Changes

Structure Refactor

  • Move CLI commands from internal/cli/ to cmd/cli/app/
  • Follows established patterns from kubectl plugins (Kueue)
  • Keeps main.go minimal with command construction in app/ package

Code Consolidation

  • Consolidate pause.go, resume.go, disable.go, enable.golifecycle.go
  • Shared newLifecycleCmd() helper with config-driven behavior
  • Refactor tests to use table-driven approach (lifecycle_test.go)

Linter Fixes

  • Fix line length violation in package_rerun.go (212 → multi-line function signature)
  • Eliminate duplicate code warnings via consolidation and //nolint:dupl where appropriate

@t0mmylam t0mmylam merged commit c054e13 into main Dec 18, 2025
9 checks passed
@t0mmylam t0mmylam deleted the cli-refactor branch December 18, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants