feat(cli): Add lifecycle management commands (pause, resume, disable, enable) #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0mmylam
requested review from
ayuskauskas,
lockwobr,
mskalka and
riceriley59
as code owners
lockwobr
reviewed
Dec 15, 2025
Comment on lines
+38
to
+50
| - script: | ||
| timeout: 30s | ||
| content: | | ||
| echo "Waiting for Skyhook to be created..." | ||
| for i in $(seq 1 15); do | ||
| if kubectl get skyhook cli-lifecycle-test 2>/dev/null; then | ||
| echo "Skyhook created" | ||
| exit 0 | ||
| fi | ||
| sleep 2 | ||
| done | ||
| echo "Timeout waiting for Skyhook" | ||
| exit 1 |
Collaborator
There was a problem hiding this comment.
lockwobr
reviewed
Dec 15, 2025
Comment on lines
38
to
52
| - script: | ||
| timeout: 60s | ||
| content: | | ||
| NODE=$(kubectl get nodes -l skyhook.nvidia.com/test-node=skyhooke2e -o jsonpath='{.items[0].metadata.name}') | ||
| echo "Waiting for Skyhook activity on node $NODE..." | ||
| for i in $(seq 1 30); do | ||
| ANNOTATION=$(kubectl get node "$NODE" -o jsonpath='{.metadata.annotations.skyhook\.nvidia\.com/nodeState_cli-node-test}' 2>/dev/null) | ||
| if [ -n "$ANNOTATION" ]; then | ||
| echo "Skyhook activity detected" | ||
| exit 0 | ||
| fi | ||
| sleep 2 | ||
| done | ||
| echo "Timeout waiting for activity" | ||
| exit 1 |
lockwobr
reviewed
Dec 15, 2025
Comment on lines
37
to
51
| - script: | ||
| timeout: 60s | ||
| content: | | ||
| NODE=$(kubectl get nodes -l skyhook.nvidia.com/test-node=skyhooke2e -o jsonpath='{.items[0].metadata.name}') | ||
| echo "Waiting for Skyhook activity on node $NODE..." | ||
| for i in $(seq 1 30); do | ||
| ANNOTATION=$(kubectl get node "$NODE" -o jsonpath='{.metadata.annotations.skyhook\.nvidia\.com/nodeState_cli-package-test}' 2>/dev/null) | ||
| if [ -n "$ANNOTATION" ]; then | ||
| echo "Skyhook activity detected" | ||
| exit 0 | ||
| fi | ||
| sleep 2 | ||
| done | ||
| echo "Timeout waiting for activity" | ||
| exit 1 |
lockwobr
reviewed
Dec 15, 2025
| delete(node.Labels, v1alpha1.NodeIgnoreLabel) | ||
| } | ||
|
|
||
| _, err := kubeClient.Kubernetes().CoreV1().Nodes().Update(ctx, node, metav1.UpdateOptions{}) |
Collaborator
There was a problem hiding this comment.
I think we should do a patch for this change.
lockwobr
reviewed
Dec 15, 2025
| // Remove the Skyhook annotation | ||
| delete(node.Annotations, annotationKey) | ||
|
|
||
| _, err := kubeClient.Kubernetes().CoreV1().Nodes().Update(ctx, node, metav1.UpdateOptions{}) |
Collaborator
There was a problem hiding this comment.
We should do a merge for this as well. merge is more efficient.
t0mmylam
added a commit
that referenced
this pull request
Dec 17, 2025
* feat(cli): Add node management commands and ignore label support * feat: Consolidate CLI e2e tests with proper assertions and CI integration * feat(cli): Add lifecycle management commands (pause, resume, disable, enable) (#127) * feat(cli): Add lifecycle management commands (pause, resume, disable, enable) * update k8s tests * change to patch
t0mmylam
added a commit
that referenced
this pull request
Dec 17, 2025
* feat(cli): Add node management commands and ignore label support * feat: Consolidate CLI e2e tests with proper assertions and CI integration * feat(cli): Add lifecycle management commands (pause, resume, disable, enable) (#127) * feat(cli): Add lifecycle management commands (pause, resume, disable, enable) * update k8s tests * change to patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds CLI commands to control Skyhook lifecycle via annotations:
skyhook pause <name>- Stops processing new nodes (setsskyhook.nvidia.com/pause)skyhook resume <name>- Resumes a paused Skyhookskyhook disable <name>- Completely disables a Skyhook (setsskyhook.nvidia.com/disable)skyhook enable <name>- Re-enables a disabled SkyhookChanges
operator/internal/cli/utils/utils.gok8s-tests/chainsaw/cli/lifecycle/