Skip to content

Conversation

@MaggieXJZhang
Copy link
Collaborator

@MaggieXJZhang MaggieXJZhang commented Nov 16, 2023

This PR fixes lots of the typos and inconsistencies between the three CSPs:

  • A few typo fixes + rewording from README file for gke module is too vague about required permissions #6
  • Added a note about stopping using changelog with pointer to the release page.
  • Aligned all readmes to use the same from of terraform plan -out tfplan and added tfplan to gitignore.
    * Note: previously on AKS: terraform plan -out plan.tf and the .tf actually confuses terraform and causes an error.

@MaggieXJZhang MaggieXJZhang force-pushed the chore/readme-typo-fixes branch from ffeee28 to aff3350 Compare November 16, 2023 22:26
…sion

Update cnpack apiVersion to v1alpha3
CHANGELOG.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to just delete the changelog. We have kept the release notes in the release page as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

@MaggieXJZhang MaggieXJZhang merged commit 5b4cabc into main Nov 17, 2023
@MaggieXJZhang MaggieXJZhang deleted the chore/readme-typo-fixes branch November 17, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants