Skip to content

Conversation

@MaggieXJZhang
Copy link
Collaborator

This MR creates a new variable called gpu_operator_namespace_labels which allows user to add any additional labels they want to add on the GPU operator namespace.

Without this, any changes to the GPU operator namespace labels can easily be overwritten by Terraform commands.

@MaggieXJZhang MaggieXJZhang force-pushed the magzhang/add-gpu-operator-ns-labels branch from b833c04 to 28ee5cc Compare October 10, 2023 19:45
Copy link
Collaborator

@ikatz-nvidia ikatz-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evberrypi
Copy link
Collaborator

@MaggieXJZhang
Copy link
Collaborator Author

Should we instead use the GPU operator value daemonsets.labels? https://github.com/NVIDIA/gpu-operator/blob/73d41d465188543f3ba093889b728e50564e74c7/deployments/gpu-operator/values.yaml#L28C5-L28C5

@evberrypi The link you have is labeling the Daemonset, what we need is the label on the GPU Operator namespace, which the GPU operator helm chart does not control, and is instead controlled by TF here. Please review again.

Copy link
Collaborator

@evberrypi evberrypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@evberrypi evberrypi merged commit 1ded885 into main Oct 10, 2023
MaggieXJZhang added a commit that referenced this pull request Oct 18, 2023
@MaggieXJZhang MaggieXJZhang deleted the magzhang/add-gpu-operator-ns-labels branch January 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants