Skip to content

Conversation

@ArangoGutierrez
Copy link
Collaborator

No description provided.

dependabot bot and others added 30 commits July 21, 2025 00:23
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.29.17 to 1.29.18.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@config/v1.29.17...config/v1.29.18)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.29.18
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
The Execute method had redundant template execution logic that was
already handled earlier in the function. This change removes the
duplicate code block to clean up the implementation.

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
….com/aws/aws-sdk-go-v2/config-1.29.18

Bump github.com/aws/aws-sdk-go-v2/config from 1.29.17 to 1.29.18
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.37.0 to 1.38.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.37.0...v1.38.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-version: 1.38.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/onsi/gomega-1.38.0

Bump github.com/onsi/gomega from 1.37.0 to 1.38.0
Bumps [github.com/aws/aws-sdk-go-v2/service/ssm](https://github.com/aws/aws-sdk-go-v2) from 1.60.0 to 1.60.2.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.60.0...service/ssm/v1.60.2)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ssm
  dependency-version: 1.60.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/service/ssm-1.60.2

Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.60.0 to 1.60.2
Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.232.0 to 1.234.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.232.0...service/ec2/v1.234.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-version: 1.234.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/service/ec2-1.234.0

Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.232.0 to 1.234.0
Remove duplicate template execution code in container-toolkit.go
- Add utils.GetIPAddress() with HTTP-based IP detection services
- Implement fallback services (ipify.org, ifconfig.me, icanhazip.com, ident.me)
- Add timeout protection (15s overall, 5s per service) and context support
- Include IP validation and proper CIDR notation (/32) for AWS API
- Use utils.GetIPAddress() in AWS security group creation
- Fix "CIDR block malformed" error in security group creation

The new utils package provides reliable public IP detection with proper
CIDR formatting, ensuring AWS security groups are created with valid
IP ranges for external access.

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Create IP detection utils and use in AWS security group creation
Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.234.0 to 1.235.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.234.0...service/ec2/v1.235.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-version: 1.235.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/service/ec2-1.235.0

Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.234.0 to 1.235.0
Bumps [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/kubernetes-sigs/yaml/releases)
- [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/yaml@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/yaml
  dependency-version: 1.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…8s.io/yaml-1.6.0

Bump sigs.k8s.io/yaml from 1.5.0 to 1.6.0
Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.235.0 to 1.236.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.235.0...service/ec2/v1.236.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-version: 1.236.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/service/ec2-1.236.0

Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.235.0 to 1.236.0
Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.36.6 to 1.37.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@v1.36.6...v1.37.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-version: 1.37.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2-1.37.0

Bump github.com/aws/aws-sdk-go-v2 from 1.36.6 to 1.37.0
Bumps [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) from 1.236.0 to 1.237.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.236.0...service/ec2/v1.237.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-version: 1.237.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/service/ec2-1.237.0

Bump github.com/aws/aws-sdk-go-v2/service/ec2 from 1.236.0 to 1.237.0
Bumps [github.com/aws/aws-sdk-go-v2/service/ssm](https://github.com/aws/aws-sdk-go-v2) from 1.60.2 to 1.61.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ssm/v1.60.2...service/s3/v1.61.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ssm
  dependency-version: 1.61.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/service/ssm-1.61.0

Bump github.com/aws/aws-sdk-go-v2/service/ssm from 1.60.2 to 1.61.0
dependabot bot and others added 6 commits July 30, 2025 12:39
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.29.18 to 1.30.1.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@config/v1.29.18...v1.30.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.30.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
….com/aws/aws-sdk-go-v2/config-1.30.1

Bump github.com/aws/aws-sdk-go-v2/config from 1.29.18 to 1.30.1
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Fix containerd and CNI install
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ArangoGutierrez ArangoGutierrez self-assigned this Jul 30, 2025
@ArangoGutierrez ArangoGutierrez requested review from Copilot and removed request for cdesiniotis, elezar and tariq1890 July 30, 2025 14:37
@ArangoGutierrez
Copy link
Collaborator Author

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 30, 2025

/ok to test

@ArangoGutierrez, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares for release 0.2.14 with automatic IP detection functionality for AWS environments, eliminates the need for manual IP configuration in security groups, and includes various improvements to containerd configuration and test coverage.

  • Introduces automatic public IP detection to simplify AWS security group configuration
  • Updates containerd default version and unifies configuration for better compatibility
  • Adds interactive provisioning failure handling with cleanup options

Reviewed Changes

Copilot reviewed 28 out of 936 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/utils/ip.go New IP detection utility with fallback services and validation
pkg/provider/aws/create.go Integrates automatic IP detection into security group creation
api/holodeck/v1alpha1/types.go Fixes typo in field name from IngresIpRanges to IngressIpRanges
pkg/provisioner/templates/containerd.go Updates default version to 1.7.28 and unifies configuration
cmd/cli/create/create.go Adds interactive provisioning failure handling
tests/data/*.yml Removes hardcoded IP ranges from test configurations
docs/ Updates documentation to reflect automatic IP detection
examples/ Updates example configurations with optional IP ranges
Comments suppressed due to low confidence (1)

tests/aws_test.go:105

  • The test removes validation for IngresIpRanges but doesn't add validation for the new automatic IP detection functionality. Consider adding a test to verify that IP ranges are properly populated after automatic detection.
		Expect(state.opts.cfg.Spec.Instance.Region).NotTo(BeEmpty(), "Region should not be empty")

return fmt.Errorf("failed to execute container-toolkit template: %v", err)
}

return nil
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template execution code was removed but the template variable containerTlktTemplate is still defined and used. This will cause the template to not be executed, resulting in incomplete container toolkit setup.

Copilot uses AI. Check for mistakes.
if err != nil {
return "", fmt.Errorf("error fetching IP from %s: %v", url, err)
}
defer resp.Body.Close() // nolint:errcheck, gosec, staticcheck
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using nolint directives to suppress error checking on resp.Body.Close() is not recommended. Consider checking the error or using a blank identifier assignment if the error is intentionally ignored.

Suggested change
defer resp.Body.Close() // nolint:errcheck, gosec, staticcheck
defer func() {
if err := resp.Body.Close(); err != nil {
fmt.Printf("warning: error closing response body: %v\n", err)
}
}()

Copilot uses AI. Check for mistakes.
@ArangoGutierrez
Copy link
Collaborator Author

/ok to test 14a7880

@ArangoGutierrez ArangoGutierrez merged commit ae9feb4 into release-0.2 Jul 30, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants