Only generate ginkgo logs on gpu test #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
requested review from
cdesiniotis,
elezar and
tariq1890
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the test command in the Makefile and updates the E2E workflow to conditionally generate a JSON report only for tests labeled "default."
- Removed the redundant --json-report flag from the Makefile test target.
- Introduced conditional logic in the E2E workflow to include the JSON report flag only for the "default" test label.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Makefile | Removed --json-report flag to simplify command execution. |
| .github/workflows/e2e.yaml | Added conditional logic to selectively generate ginkgo.json reports. |
Pull Request Test Coverage Report for Build 15363661883Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the end-to-end (E2E) testing workflow and the
Makefilefor test execution. The updates introduce conditional logic for generating JSON reports only for specific test labels and simplify the test command in theMakefile.Updates to E2E Testing Workflow:
.github/workflows/e2e.yaml: Added conditional logic to generate aginkgo.jsonreport when the test label is "default." This ensures JSON reports are only created for the default test suite, optimizing artifact generation.Changes to Test Execution in
Makefile:tests/Makefile: Removed the--json-report ginkgo.jsonflag from the default test command, as this is now handled conditionally in the workflow configuration. This simplifies theMakefilelogic.