-
Notifications
You must be signed in to change notification settings - Fork 9
Update dependabot file #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c96f432 to
2a8a07d
Compare
2a8a07d to
7c25961
Compare
|
@elezar I am updating the dependabot file to see if this triggers an actual go 1.24 bump |
7c25961 to
d4551a4
Compare
| SCRIPTS_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../hack && pwd )" | ||
|
|
||
| DOCKERFILE_ROOT=${SCRIPTS_DIR}/../deployments/devel | ||
| DOCKERFILE_ROOT="${SCRIPTS_DIR}/.." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Given that we use FROM golang:1.23-bookworm AS builder, does this properly extract the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❯ ./hack/golang-version.sh
1.23There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually use this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elezar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question.
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
d4551a4 to
081325e
Compare
No description provided.