Skip to content

Conversation

@os14
Copy link

@os14 os14 commented Dec 14, 2025

Overview

This PR addresses the usage of HTTP for repository URLs in the script. Currently, the script uses HTTP for fetching packages from Ubuntu repositories, and i'm uncertain whether this choice was intentional.

Changes

  • Replaced HTTP URLs with HTTPS URLs for Ubuntu package repositories in the repo_setup function.

Motivation and Context

The primary motivation for this change is to improve security by migrating to HTTPS, which ensures that all communication with the repository is encrypted. This is especially important for protecting the integrity and authenticity of the packages being downloaded.

Although HTTP still works, it lacks the encryption layer provided by HTTPS, which makes it vulnerable to interception and tampering. Migrating to HTTPS ensures that the system is protected from these security risks.

Additionally, some air-gapped environments or highly restricted networks may block outbound HTTP traffic on port 80, which could prevent the script from successfully fetching packages. In such cases, using HTTPS (typically over port 443) is often the only available option to access external repositories. Migrating to HTTPS ensures compatibility with these environments.

If maintaining HTTP support is still desired, I can modify the script to offer the option to use either HTTP or HTTPS, based on user preference.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant