-
Notifications
You must be signed in to change notification settings - Fork 71
Simple diving for Branch-and-Bound #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.10
Are you sure you want to change the base?
Conversation
Signed-off-by: nicolas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a bit bigger than I had envisioned.
I'm not sure we want to make the strategy (i.e. depth first vs best first) a user accessible parameter. But rather keep it an internal parameter.
Given the number of changes, I think we need to verify this PR before merging. Let's discuss the verification strategy.
Implement a test for verifying the different search strategies. But I can also add some unit testing. Is there any other verification strategy that you have in mind? |
/ok to test 56a061d |
/ok to test 7b713d8 |
/ok to test db73ba4 |
/ok to test f9fb5ad |
/ok to test 041e104 |
This PR introduces the following changes:
BEST_FIRST
,DEPTH_FIRST
andMULTITHREADED_BEST_FIRST_WITH_DIVING
solve
function is now organized into separated methods