Skip to content

Fix CMake dependence issue for scaleway target#4249

Merged
khalatepradnya merged 1 commit intoNVIDIA:mainfrom
khalatepradnya:fix-cmake-scaleway
Apr 4, 2026
Merged

Fix CMake dependence issue for scaleway target#4249
khalatepradnya merged 1 commit intoNVIDIA:mainfrom
khalatepradnya:fix-cmake-scaleway

Conversation

@khalatepradnya
Copy link
Copy Markdown
Collaborator

@khalatepradnya khalatepradnya commented Apr 3, 2026

  • This PR fixes the existing bug that was exposed by changes in [CMake] Unify CUDA setup, fix cudaq linkage vis #4238
  • Recently we moved MLIRIR from PUBLIC to PRIVATE in the cudaq target to avoid leaking MLIR IR dependencies to consumers.
  • As a result, zlib stopped propagating to cudaq-rest-qpu (which is the expected correct behavior)

Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
Copy link
Copy Markdown
Collaborator

@mitchdz mitchdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @khalatepradnya

github-actions bot pushed a commit that referenced this pull request Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya added this pull request to the merge queue Apr 3, 2026
@khalatepradnya khalatepradnya removed this pull request from the merge queue due to a manual request Apr 3, 2026
@khalatepradnya khalatepradnya added this pull request to the merge queue Apr 3, 2026
Merged via the queue into NVIDIA:main with commit 9f8c692 Apr 4, 2026
396 of 397 checks passed
@khalatepradnya khalatepradnya deleted the fix-cmake-scaleway branch April 4, 2026 02:34
github-actions bot pushed a commit that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants