Skip to content

Cye/fix test pypi publish #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polinabinder1 merged 2 commits into from
Jun 17, 2025
Merged

Cye/fix test pypi publish #947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be872f
Fix boolean logic for PyPI publish environment variables.
cspades Jun 16, 2025
18fcfdb
Fix docstring for Test PyPI and PyPI jobs.
cspades Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/bionemo-subpackage-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ jobs:
name: Publish ${{ matrix.package }} to PyPI.
runs-on: ubuntu-latest
environment:
name: ${{ github.event.inputs.pypi && 'pypi' || 'testpypi' }}
name: ${{ github.event.inputs.pypi == 'true' && 'pypi' || 'testpypi' }}
url: ${{ github.event.inputs.pypi && format('https://pypi.org/p/{0}', matrix.package) || format('https://test.pypi.org/p/{0}', matrix.package) }}
permissions:
id-token: write
Expand All @@ -205,7 +205,7 @@ jobs:
name: ${{ matrix.package }}-build-artifacts
path: sub-packages/${{ matrix.package }}/dist
- id: publish-to-testpypi
name: Publish distribution 📦 to Test PyPI for PR.
name: Publish distribution 📦 to Test PyPI.
if: ${{ github.event.inputs.pypi == 'false' }}
uses: pypa/gh-action-pypi-publish@release/v1
with:
Expand All @@ -214,7 +214,7 @@ jobs:
repository-url: https://test.pypi.org/legacy/
skip-existing: ${{ github.event.inputs.version_overwrite }}
- id: publish-to-pypi
name: Publish distribution 📦 to PyPI for Workflow Dispatch.
name: Publish distribution 📦 to PyPI.
# To require testing before publishing to PyPI, add: ... && needs.install-and-test.result == 'success'
# If testing is run but fails, the workflow will fail and not publish to PyPI (or Test PyPI).
# We strongly recommend testing when publishing to production PyPI.
Expand Down
Loading