[cye/subpack-gpu-testing] Add GPU runner to testing job. #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspades
requested review from
dorotat-nv,
jstjohn,
pstjohn and
trvachov
as code owners
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
c821a86 to
455243c
Compare
pstjohn
reviewed
Mar 21, 2025
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
455243c to
1d2eb29
Compare
pstjohn
reviewed
Mar 21, 2025
cspades
requested review from
DejunL,
guoqing-zhou,
malcolmgreaves,
nvdreidenbach,
sichu2023,
youhanl-nvidia and
zcao0420
as code owners
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
39186b9 to
f7b4052
Compare
Member
Author
|
/ok to test |
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
f3f76bd to
10afe16
Compare
Member
Author
|
/ok to test |
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
10afe16 to
6b5de94
Compare
Member
Author
|
/ok to test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
=======================================
Coverage 84.30% 84.30%
=======================================
Files 137 137
Lines 8635 8635
=======================================
Hits 7280 7280
Misses 1355 1355 ☔ View full report in Codecov by Sentry. |
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
6b5de94 to
84e17e5
Compare
Member
Author
|
/ok to test |
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
84e17e5 to
2af1a30
Compare
Member
Author
|
/ok to test |
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
1538e03 to
dad7b7e
Compare
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
dad7b7e to
e22053c
Compare
Signed-off-by: Cory Ye <[email protected]> Signed-off-by: cspades <[email protected]>
Signed-off-by: Cory Ye <[email protected]> Signed-off-by: cspades <[email protected]>
Signed-off-by: Cory Ye <[email protected]>
Signed-off-by: Cory Ye <[email protected]>
…ow dispatches. Signed-off-by: Cory Ye <[email protected]>
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
e22053c to
d12a019
Compare
Member
Author
|
/ok to test |
jomitchellnv
approved these changes
Apr 2, 2025
pstjohn
reviewed
Apr 2, 2025
pstjohn
approved these changes
Apr 2, 2025
Collaborator
pstjohn
left a comment
pstjohn
left a comment
There was a problem hiding this comment.
LGTM after the optional-dependencies bit
…when publishing untested packages to PyPI. Signed-off-by: Cory Ye <[email protected]>
cspades
force-pushed
the
cye/subpack-gpu-testing
branch
from
d12a019 to
1c423f6
Compare
Member
Author
|
/ok to test |
cspades
added a commit
that referenced
this pull request
May 4, 2025
### Description <!-- Provide a detailed description of the changes in this PR --> - Add GPU runners to BioNeMo Sub-Package CI workflow. - https://jirasw.nvidia.com/browse/BIONEMO-1340 ### Details - GHA GPU Runner Documentation: https://docs.gha-runners.nvidia.com/runners/#gpu-runners - NVIDIA CUDA Container Images: https://catalog.ngc.nvidia.com/orgs/nvidia/containers/cuda/tags - Installing CUDA is presumed out-of-scope of BioNeMo Framework. - BioNeMo Sub-Package Updates - GPU Testing PASS Checklist - `bionemo-moco` ✅ @nvdreidenbach - `bionemo-webdatamodule` ✅ @DejunL - `bionemo-size-aware-batching` ✅ @DejunL - `bionemo-core` ✅ - `bionemo-testing` ✅ - TODO after TransformerEngine is installed, otherwise they are not functional. (https://jirasw.nvidia.com/browse/BIONEMO-1341) - `bionemo-llm` 🚧 - `bionemo-amplify` - `bionemo-esm2` - `bionemo-evo2` - `bionemo-geneformer` ### Usage <!--- How does a user interact with the changed code --> - Refer to the BioNeMo Sub-Package CI documentation to run the GHA workflow: https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#contributing-python-sub-packages-to-bionemo-framework ### Testing - Latest: https://github.com/NVIDIA/bionemo-framework/actions/runs/14030539337 --------- Signed-off-by: Cory Ye <[email protected]> Signed-off-by: cspades <[email protected]> Signed-off-by: Cory Ye <[email protected]>
farhadrgh
pushed a commit
that referenced
this pull request
May 5, 2025
### Description <!-- Provide a detailed description of the changes in this PR --> - Add GPU runners to BioNeMo Sub-Package CI workflow. - https://jirasw.nvidia.com/browse/BIONEMO-1340 ### Details - GHA GPU Runner Documentation: https://docs.gha-runners.nvidia.com/runners/#gpu-runners - NVIDIA CUDA Container Images: https://catalog.ngc.nvidia.com/orgs/nvidia/containers/cuda/tags - Installing CUDA is presumed out-of-scope of BioNeMo Framework. - BioNeMo Sub-Package Updates - GPU Testing PASS Checklist - `bionemo-moco` ✅ @nvdreidenbach - `bionemo-webdatamodule` ✅ @DejunL - `bionemo-size-aware-batching` ✅ @DejunL - `bionemo-core` ✅ - `bionemo-testing` ✅ - TODO after TransformerEngine is installed, otherwise they are not functional. (https://jirasw.nvidia.com/browse/BIONEMO-1341) - `bionemo-llm` 🚧 - `bionemo-amplify` - `bionemo-esm2` - `bionemo-evo2` - `bionemo-geneformer` ### Usage <!--- How does a user interact with the changed code --> - Refer to the BioNeMo Sub-Package CI documentation to run the GHA workflow: https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#contributing-python-sub-packages-to-bionemo-framework ### Testing - Latest: https://github.com/NVIDIA/bionemo-framework/actions/runs/14030539337 --------- Signed-off-by: Cory Ye <[email protected]> Signed-off-by: cspades <[email protected]> Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details
bionemo-moco✅ @nvdreidenbachbionemo-webdatamodule✅ @DejunLbionemo-size-aware-batching✅ @DejunLbionemo-core✅bionemo-testing✅bionemo-llm🚧bionemo-amplifybionemo-esm2bionemo-evo2bionemo-geneformerUsage
Testing