Skip to content

Conversation

@pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Mar 6, 2025

Removes zstandard after installing NeMo to avoid issues like the following downloading large binary files with ngcsdk.

https://nvbugspro.nvidia.com/bug/5149698

    raise DecodeError(
urllib3.exceptions.DecodeError: ('Received response with content-encoding: zstd, but failed to decode it.', ZstdError('cannot use a decompressobj multiple times'))
...
requests.exceptions.ContentDecodingError: ('Received response with content-encoding: zstd, but failed to decode it.', ZstdError('cannot use a decompressobj multiple times'))

Copy link
Collaborator

@trvachov trvachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you plan on attempting to remove lm-eval?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.20%. Comparing base (588fb75) to head (04c33da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   85.93%   84.20%   -1.74%     
==========================================
  Files         120      128       +8     
  Lines        7310     8020     +710     
==========================================
+ Hits         6282     6753     +471     
- Misses       1028     1267     +239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pstjohn pstjohn added this pull request to the merge queue Mar 7, 2025
Merged via the queue into NVIDIA:main with commit 957ee61 Mar 7, 2025
12 checks passed
@pstjohn pstjohn deleted the pstjohn/remove-zstandard branch March 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants