Skip to content

Conversation

@Shixiaowei02
Copy link
Collaborator

@Shixiaowei02 Shixiaowei02 commented Sep 16, 2025

Summary by CodeRabbit

  • Documentation
    • Corrected the link in “Launching disaggregated servers on SLURM clusters” to the proper examples location for SLURM-based disaggregated serving. This fixes an outdated path and makes setup steps easier to follow. Users can now access the working example without broken navigation. The anchor text remains the same.
    • No behavior, code, or API changes; this update strictly improves documentation accuracy and discoverability.

Signed-off-by: Shixiaowei02 <[email protected]>
@Shixiaowei02 Shixiaowei02 requested a review from a team as a code owner September 16, 2025 05:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

📝 Walkthrough

Walkthrough

Updated a hyperlink in docs/source/features/disagg-serving.md under “Launching disaggregated servers on SLURM clusters” to point from ../../scripts/disaggregated to ../../../examples/disaggregated/slurm. No other content or code changed.

Changes

Cohort / File(s) Summary of Changes
Docs link update
docs/source/features/disagg-serving.md
Updated hyperlink target from ../../scripts/disaggregated to ../../../examples/disaggregated/slurm; anchor text unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • laikhtewari
  • chzblych
  • QiJune

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description contains only the placeholder "@coderabbitai summary" and does not populate the repository's required template sections (Description, Test Coverage, PR Checklist, etc.), so it provides no explanation of what changed, why, or how to validate the change. Because the required template fields are missing and the body is effectively empty, the description does not meet the repository's standards. This makes the PR incomplete for review. Please replace the placeholder with the full template content: add a concise Description describing the change and rationale (for example, "Updated hyperlink target in docs/source/features/disagg-serving.md"), list Test Coverage notes or "none" for docs-only changes, and complete the PR Checklist items before marking the PR ready for review.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][doc] Fix the link in the doc" is concise, follows the repository's required bracketed format, and accurately summarizes the primary change (updating a documentation hyperlink in docs/source/features/disagg-serving.md). It is specific and clear enough for a reviewer scanning history to understand the main intent without extraneous details. Therefore it meets the project's title guidelines.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Shixiaowei02
Copy link
Collaborator Author

/bot skip --comment "doc changes"

@Shixiaowei02 Shixiaowei02 enabled auto-merge (squash) September 16, 2025 05:57
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7df515e and d42902d.

📒 Files selected for processing (1)
  • docs/source/features/disagg-serving.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18724 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18724 [ skip ] completed with state SUCCESS
Skipping testing for commit d42902d

@Shixiaowei02 Shixiaowei02 merged commit 7cf1d5a into NVIDIA:release/1.0 Sep 16, 2025
5 checks passed
@Shixiaowei02 Shixiaowei02 deleted the user/xiaoweis/fix-doc-1.0 branch September 16, 2025 07:49
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 18, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 18, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 18, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
Signed-off-by: Shixiaowei02 <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants