Skip to content

Conversation

@yizhang-nv
Copy link
Member

@yizhang-nv yizhang-nv commented Sep 15, 2025

Summary by CodeRabbit

  • Tests
    • Added MOE backend latency scenarios for LLM PyTorch tests, including attention-parallelism disabled and eagle3 toggles; extended test parameterization and test lists to cover these cases.
  • Chores
    • Expanded CI multi-node test matrix with one additional GB200 multi-node configuration.
  • Tests (Waivers)
    • Added skip for a failing eagle3+attention_dp latency case.
  • Bug Fixes
    • Model now detects GPU peer-to-peer support and adapts MoE finalization for improved hardware compatibility.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

📝 Walkthrough

Walkthrough

Adds TRTLLM MOE parameter combinations (with eagle3 and attention_dp variants) to LLM PyTorch latency tests, updates test method signatures to accept moe_backend, inserts a new multi-node TIMEOUT entry, extends Jenkins multi-node config range, adds a waiver, and makes P2P-aware gating changes in the Qwen3 MoE model finalization logic.

Changes

Cohort / File(s) Summary
LLM PyTorch latency tests
tests/integration/defs/accuracy/test_llm_api_pytorch.py
Added parameterized TRTLLM MOE cases (attention_dp on/off) including eagle3 on/off; extended test_fp8 and test_nvfp4 signatures to accept moe_backend and eagle3; added test ids like latency_moe_trtllm, latency_moe_trtllm_attention_dp, latency_moe_trtllm_eagle3, latency_moe_trtllm_eagle3_attention_dp.
Test list DB update
tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml
Inserted one new TIMEOUT entry: accuracy/test_llm_api_pytorch.py::TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm_attention_dp] TIMEOUT (90) (placed after existing latency_moe_trtllm).
Jenkins multi-node configs
jenkins/L0_Test.groovy
Expanded multiNodesSBSAConfigs iteration from 1..7 to 1..8 and changed per-entry config to use split_count=8 (was 7), adding one additional GB200-8_GPUs-2_Nodes config.
Test waivers
tests/integration/test_lists/waives.txt
Added one SKIP waiver: accuracy/test_llm_api_pytorch.py::TestQwen3_235B_A22B::test_nvfp4[latency_moe_trtllm_eagle3_attention_dp] SKIP (https://nvbugs/5437384).
Qwen3 MoE model (runtime behavior)
tensorrt_llm/_torch/models/modeling_qwen3_moe.py
Added can_access_peer import/use to compute is_p2p_supported from modelConfig.mapping; introduced is_p2p_supported flag in Qwen3MoE and Qwen3MoEDecoderLayer initializers and used it to condition the Post-MOE fusion finalization path in forward (gates do_finalize behavior when P2P not supported).

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test/Runner
    participant ModelConfig as ModelConfig
    participant MoE as Qwen3MoE
    participant Layer as Qwen3MoEDecoderLayer
    note right of ModelConfig #D3E4CD: runtime mapping info

    Test->>ModelConfig: provide mapping
    ModelConfig->>MoE: init with mapping
    MoE->>ModelConfig: call can_access_peer(mapping)
    ModelConfig-->MoE: is_p2p_supported (true/false)
    MoE->>Layer: init layer with is_p2p_supported
    Test->>MoE: forward(input)
    MoE->>Layer: call forward
    alt is_p2p_supported == true
        Layer->>Layer: perform Post-MOE fusion finalization (do_finalize allowed)
    else is_p2p_supported == false
        Layer->>Layer: skip/fallback finalization path (do_finalize gated)
    end
    Layer-->MoE: output
    MoE-->Test: final output
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • bobboli

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is still the repository template with empty Description and Test Coverage sections and does not explain what was changed, why, or which tests cover the change, leaving reviewers without required context. Although the raw_summary and pr_objectives contain details, the PR body itself fails to document the change set, test coverage, and checklist confirmations required by the template. Because the description is essentially unfilled, the check fails. Please populate the PR Description with a concise summary of the changes and rationale (mention TRTLLM MOE test additions, Jenkins multi-node config change, and P2P-aware Qwen3 MoE code updates), add a Test Coverage section listing new/modified tests and any waivers, and confirm PR checklist items including coding guideline adherence and links to CI runs/NVBugs.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title uses a valid NVBugs link and the [fix] type and concisely describes the primary changes (TRTLLM MoE backend test configuration fixes and Qwen3 MoE multi-node adjustments). The raw_summary shows test-matrix updates adding TRTLLM MOE cases, Jenkins multi-node SBSA config changes, and related model code tweaks, which the title covers and is not misleading. The phrasing is specific enough for a reviewer scanning history to understand the primary intent.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yizhang-nv yizhang-nv marked this pull request as ready for review September 15, 2025 09:56
@yizhang-nv yizhang-nv requested a review from a team as a code owner September 15, 2025 09:56
@yizhang-nv yizhang-nv changed the title [https://nvbug/5355219][fix] Fix trtllm moe backend test config [https://nvbugs/5355219][fix] Fix trtllm moe backend test config Sep 15, 2025
@yizhang-nv
Copy link
Member Author

/bot run

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/integration/defs/accuracy/test_llm_api_pytorch.py (1)

2294-2310: Add sanity asserts for backend and quant algo

Guard against misconfig by asserting expected MOE backend and NVFP4 quantization in this test.

@@ def test_nvfp4(...):
-        with LLM(
+        with LLM(
                 f"{llm_models_root()}/Qwen3/saved_models_Qwen3-235B-A22B_nvfp4_hf",
                 tensor_parallel_size=tp_size,
                 pipeline_parallel_size=pp_size,
                 moe_expert_parallel_size=ep_size,
                 **pytorch_config,
                 enable_attention_dp=attention_dp,
                 kv_cache_config=kv_cache_config,
                 speculative_config=spec_config) as llm:
+            # Sanity checks to catch mismatched artifacts/configs
+            assert llm.args.moe_config.backend == moe_backend
+            assert llm.args.quant_config.quant_algo == QuantAlgo.NVFP4
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d40adb and a6cd518.

📒 Files selected for processing (2)
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py (1 hunks)
  • tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
🧠 Learnings (4)
📓 Common learnings
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Learnt from: Funatiq
PR: NVIDIA/TensorRT-LLM#6754
File: tests/integration/test_lists/test-db/l0_a30.yml:41-47
Timestamp: 2025-08-13T11:07:11.772Z
Learning: In TensorRT-LLM test configuration files like tests/integration/test_lists/test-db/l0_a30.yml, TIMEOUT values are specified in minutes, not seconds.
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
📚 Learning: 2025-08-13T11:07:11.772Z
Learnt from: Funatiq
PR: NVIDIA/TensorRT-LLM#6754
File: tests/integration/test_lists/test-db/l0_a30.yml:41-47
Timestamp: 2025-08-13T11:07:11.772Z
Learning: In TensorRT-LLM test configuration files like tests/integration/test_lists/test-db/l0_a30.yml, TIMEOUT values are specified in minutes, not seconds.

Applied to files:

  • tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/defs/accuracy/test_llm_api_pytorch.py (1)

2294-2310: TRTLLM MOE NVFP4 variants added correctly

Param tuples and ids are consistent; gating (skip on SM120/121) and EAGLE3 spec config wiring look sound. KV block‑reuse disabled only for EAGLE3 is reasonable.

tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml (2)

21-21: New multi‑node entry matches test id and timeout policy

The id aligns with the added parametrization and TIMEOUT is in minutes (90), consistent with test‑db conventions.


21-21: Verified — test id wiring OK

Parameter 'latency_moe_trtllm_attention_dp' found in defs at tests/integration/defs/accuracy/test_llm_api_pytorch.py:2305 and referenced once in test-db at tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml:21.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18610 [ run ] triggered by Bot

@yizhang-nv yizhang-nv force-pushed the fix-trtllm-test-config branch from a6cd518 to 14dfb66 Compare September 15, 2025 10:06
@yizhang-nv
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18612 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18610 [ run ] completed with state ABORTED
LLM/release-1.0/L0_MergeRequest_PR #388 (Blue Ocean) completed with status: ABORTED

@yizhang-nv yizhang-nv force-pushed the fix-trtllm-test-config branch from 14dfb66 to 9270ea4 Compare September 15, 2025 10:43
@yizhang-nv yizhang-nv changed the title [https://nvbugs/5355219][fix] Fix trtllm moe backend test config [https://nvbugs/5355219][fix] Fix trtllm moe backend test config and Qwen3 MoE multi node Sep 15, 2025
@yizhang-nv
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18617 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18612 [ run ] completed with state ABORTED
LLM/release-1.0/L0_MergeRequest_PR #389 (Blue Ocean) completed with status: ABORTED

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/models/modeling_qwen3_moe.py (1)

1-1: Missing NVIDIA Apache-2.0 header (compliance).

Add the 2025 NVIDIA Apache-2.0 header at the file top.

Apply:

+# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#     http://www.apache.org/licenses/LICENSE-2.0
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
🧹 Nitpick comments (1)
tensorrt_llm/_torch/models/modeling_qwen3_moe.py (1)

191-191: Avoid repeated cudaDeviceCanAccessPeer scans per layer (cache once).

Minor perf/log noise nit: this runs once per layer; cache per process.

Apply within this line:

-        self.is_p2p_supported = can_access_peer(model_config.mapping)
+        self.is_p2p_supported = _get_p2p_supported(model_config.mapping)

Add the helper near imports (outside this hunk):

_P2P_SUPPORTED_CACHE = None

def _get_p2p_supported(mapping):
    global _P2P_SUPPORTED_CACHE
    if _P2P_SUPPORTED_CACHE is None:
        _P2P_SUPPORTED_CACHE = can_access_peer(mapping)
    return _P2P_SUPPORTED_CACHE
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14dfb66 and 9270ea4.

📒 Files selected for processing (6)
  • jenkins/L0_Test.groovy (1 hunks)
  • tensorrt_llm/_torch/models/modeling_qwen3_moe.py (3 hunks)
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py (1 hunks)
  • tests/integration/test_lists/qa/llm_function_full.txt (1 hunks)
  • tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml (1 hunks)
  • tests/integration/test_lists/waives.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • tests/integration/test_lists/waives.txt
🚧 Files skipped from review as they are similar to previous changes (3)
  • tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml
  • jenkins/L0_Test.groovy
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tensorrt_llm/_torch/models/modeling_qwen3_moe.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tensorrt_llm/_torch/models/modeling_qwen3_moe.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tensorrt_llm/_torch/models/modeling_qwen3_moe.py
🧠 Learnings (3)
📓 Common learnings
Learnt from: djns99
PR: NVIDIA/TensorRT-LLM#7104
File: cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu:1475-1480
Timestamp: 2025-08-21T02:39:12.009Z
Learning: The min latency mode functionality in TensorRT-LLM MOE kernels (cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_kernels.cu) is deprecated and no longer being maintained/updated, as confirmed by djns99. Bug reports and optimization suggestions for the computeStridesTmaWarpSpecializedLowLatencyKernel and related min latency code paths should be deprioritized.
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/qa/llm_function_full.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/qa/llm_function_full.txt
🧬 Code graph analysis (1)
tensorrt_llm/_torch/models/modeling_qwen3_moe.py (3)
tensorrt_llm/_ipc_utils.py (1)
  • can_access_peer (37-61)
tensorrt_llm/_torch/models/checkpoints/base_weight_mapper.py (1)
  • mapping (152-153)
tensorrt_llm/_torch/modules/fused_moe/interface.py (1)
  • has_nvfp4 (121-124)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tensorrt_llm/_torch/models/modeling_qwen3_moe.py (2)

8-8: P2P capability import — OK.

Localizes the decision to runtime feasibility checks; import path is correct.


248-252: POST‑MoE fusion gating now checks P2P support — good safeguard.

Short‑circuit order keeps the has_nvfp4 assertion cold when earlier conditions fail.

tests/integration/test_lists/qa/llm_function_full.txt (1)

541-541: Approve: add Qwen3-235B TRTLLM-MoE attention_dp latency test

Verified — test is present in tests/integration/test_lists/qa/llm_function_full.txt, TIMEOUT mapping exists in tests/integration/test_lists/test-db/l0_gb200_multi_nodes.yml, and the id is defined in tests/integration/defs/accuracy/test_llm_api_pytorch.py. Placement and formatting align with adjacent nvfp4 TRTLLM variants.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18617 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #390 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@byshiue byshiue merged commit 7df515e into NVIDIA:release/1.0 Sep 16, 2025
6 checks passed
@yizhang-nv yizhang-nv deleted the fix-trtllm-test-config branch September 16, 2025 02:34
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 16, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 17, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 18, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 18, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 18, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
chzblych pushed a commit that referenced this pull request Sep 22, 2025
…Qwen3 MoE multi node (#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
JunyiXu-nv pushed a commit to JunyiXu-nv/TensorRT-LLM that referenced this pull request Sep 22, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
nv-lschneider pushed a commit to nv-lschneider/TensorRT-LLM that referenced this pull request Sep 22, 2025
…Qwen3 MoE multi node (NVIDIA#7724)

Signed-off-by: Yi Zhang <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants