[https://nvbugs/5409416][fix] test_openai_multi_chat_example #7174
Conversation
📝 WalkthroughWalkthroughUpdates a test fixture in tests/unittest/llmapi/apps/_test_openai_multi_chat.py to pass additional CLI arguments to RemoteOpenAIServer: --backend trt, --max_num_tokens 20480, and --max_batch_size 128, alongside existing --tp_size 2 and --tokenizer model_path. No function signatures or control flow are modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
tests/unittest/llmapi/apps/_test_openai_multi_chat.py (3)
68-74: Nit: clarify intent by naming the list server_args and use it at the call site.Small readability win; makes the positional args in the context manager less ambiguous.
Apply:
- args = [ + server_args = [ "--tp_size", "2", "--tokenizer", model_path, "--backend", "trt", "--max_num_tokens", "20480", "--max_batch_size", "128" ] - with RemoteOpenAIServer(engine_from_fp8_quantization, - args) as remote_server: + with RemoteOpenAIServer(engine_from_fp8_quantization, + server_args) as remote_server:
68-71: Avoid config drift: derive server flags from shared constants or build_config.You set max_num_tokens/max_batch_size both in build_config and again here. To keep them in sync, either:
- hoist TP_SIZE, MAX_NUM_TOKENS, MAX_BATCH_SIZE to module-level constants and use them in both fixtures; or
- read the built engine’s config/metadata (if available in RemoteOpenAIServer) to populate defaults.
Example approach with shared constants (outside the selected lines):
# Near the top of the file TP_SIZE = 2 MAX_NUM_TOKENS = 20480 MAX_BATCH_SIZE = 128 # In engine_from_fp8_quantization() tp_size = TP_SIZE build_config.max_num_tokens = MAX_NUM_TOKENS build_config.max_batch_size = MAX_BATCH_SIZE # In server() fixture args assembly server_args = [ "--tp_size", str(TP_SIZE), "--tokenizer", model_path, "--backend", "trt", "--max_num_tokens", str(MAX_NUM_TOKENS), "--max_batch_size", str(MAX_BATCH_SIZE), ]
1-1: Add the required NVIDIA copyright header (2025).Per repo guidelines, prepend the current-year NVIDIA header.
Example:
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.(Use the exact header block used elsewhere in this repo if it includes license text.)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
tests/unittest/llmapi/apps/_test_openai_multi_chat.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+
Python indentation: 4 spaces, no tabs
Maintain module namespace in imports (from package.subpackage import foo; then use foo.SomeClass())
Python file names use snake_case
Python class names use PascalCase
Python functions/methods and local variables use snake_case; variables starting with a number get k_ prefix (e.g., k_99th_percentile)
Global variables use G_ prefixed UPPER_SNAKE_CASE (e.g., G_MY_GLOBAL)
Constants use UPPER_SNAKE_CASE in Python
Avoid shadowing variables from outer scopes in Python
Initialize all externally visible members of a Python class in init
Prefer docstrings for interfaces used outside a file; comments for local code
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes/variables inline with short docstrings
Avoid reflection when simple alternatives exist (e.g., prefer explicit parameters over dict(**locals()))
In try/except, catch the narrowest exceptions possible
For duck-typing with try/except, keep try body minimal and put logic in else
Files:
tests/unittest/llmapi/apps/_test_openai_multi_chat.py
**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend NVIDIA copyright header (current year) to all source files
Files:
tests/unittest/llmapi/apps/_test_openai_multi_chat.py
🔇 Additional comments (2)
tests/unittest/llmapi/apps/_test_openai_multi_chat.py (2)
68-71: Good: server startup now explicitly pins backend and capacity.Passing --backend trt, --max_num_tokens 20480, and --max_batch_size 128 aligns the runtime with the engine build set earlier (tp=2, max_num_tokens=20480, max_batch_size=128). The values look consistent and should reduce surprises at runtime.
68-71: No change needed: CLI supports underscore flagsA review of the codebase shows that the
trtllm-servecommand consistently uses underscores in its option names. For example, in tests/scripts/perf-sanity/run_benchmark_serve.py the invocation is:
"trtllm-serve", MODEL, "--backend", "pytorch", "--tp_size", …, "--max_batch_size", …, "--max_num_tokens", …This confirms that the underscore versions (
--tp_size,--max_batch_size,--max_num_tokens) are the canonical flags for the server process. The existing test in tests/unittest/llmapi/apps/_test_openai_multi_chat.py already matches the supported spellings, so no adjustments are required.
|
PR_Github #16197 [ run ] triggered by Bot |
Signed-off-by: Linda-Stadter <[email protected]>
|
/bot run |
|
PR_Github #16202 [ run ] triggered by Bot |
|
PR_Github #16197 [ run ] completed with state |
|
/bot run |
|
PR_Github #16266 [ run ] triggered by Bot |
|
PR_Github #16266 [ run ] completed with state |
Signed-off-by: Linda-Stadter <[email protected]>
Description
NVBugs: https://nvbugs/5409416
Because of the recent change of setting the default backend to PyTorch for
trtllm-serve, the testtest_openai_multi_chat_exampleneeds the backendtrtargument specified.Verified the test passes now with 2x NVIDIA H100 PCIe.
=== 1 passed, 5 warnings in 464.24s (0:07:44) ===GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.