[https://nvbugs/5470840][fix] Disaggregated unit test MPI Init handling #7139
Conversation
📝 WalkthroughWalkthroughAdded three MPI helper functions and replaced direct MPI port/accept/termination calls in the test with these helpers; added try/except logging and flushes; retained intercommunicator setup, request/response exchange, and termination semantics while centralizing connectivity and error handling. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant T as Test Case
participant H as MPI Helpers
participant M as MPI Runtime
rect rgb(240,248,255)
note over T,H: Setup phase (centralized)
T->>H: mpi_publish_name()
H->>M: Open_port + Publish_name('my_port')
M-->>H: port_name
H-->>T: port_name
end
rect rgb(245,255,250)
note over T,H: Connection phase
T->>H: mpi_initialize_intercomm(port_name)
H->>M: COMM_SELF.Accept(port_name)
M-->>H: intercomm
H-->>T: intercomm
end
rect rgb(255,250,240)
note over T,M: Test exchanges (unchanged semantics)
T->>M: Readiness + request/response via intercomm
M-->>T: Responses
end
rect rgb(255,240,245)
note over T,H: Termination phase (centralized)
T->>H: mpi_send_termination_request(intercomm)
H->>M: Send termination to ranks 0 and 1
M-->>T: Acknowledged/close
end
note over T: Errors handled via try/except with logging and flush
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run --disable-fail-fast |
|
PR_Github #16081 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (6)
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py (6)
39-52: Add a constant for the MPI service name and lightweight docstring; fix prints/raise usage.Hardcoding "my_port" in multiple places is brittle. Define a single constant (UPPER_SNAKE_CASE per guidelines) and reuse it across helpers and workers. Also, add a brief docstring and use flush/raise best practices.
Apply within this hunk:
-def mpi_publish_name(): +def mpi_publish_name(): + """Open an MPI port and publish it under MPI_SERVICE_NAME. + + Returns: + str: The MPI port name string. + """ port_name = None try: port_name = MPI.Open_port() - MPI.Publish_name('my_port', port_name) + MPI.Publish_name(MPI_SERVICE_NAME, port_name) except MPI.Exception as e: - print(f"Error publishing port name: {e}") - raise e + print(f"Error publishing port name: {e}", flush=True) + raise except Exception as e: - print(f"Unexpected error publishing port name: {e}") - raise e + print(f"Unexpected error publishing port name: {e}", flush=True) + raiseAnd add the constant near the other MPI constants (outside this hunk):
# Single point of truth for the service name used by Publish/Lookup MPI_SERVICE_NAME = "disagg_test_port"Also consider adding the NVIDIA copyright header at the top of the file as per repository guidelines. Want me to generate it with the current year?
68-74: Generalize termination to N workers instead of hardcoding 0 and 1.Use Get_remote_size() to avoid fragile assumptions and ease future scaling.
-def mpi_send_termination_request(intercomm): - if intercomm is not None: - # Send termination requests - intercomm.send(None, dest=0, tag=MPI_REQUEST) - intercomm.send(None, dest=1, tag=MPI_REQUEST) - print("Sent termination requests to the workers.") +def mpi_send_termination_request(intercomm): + if intercomm is not None: + for dst in range(intercomm.Get_remote_size()): + intercomm.send(None, dest=dst, tag=MPI_REQUEST) + print("Sent termination requests to the workers.", flush=True)
88-97: Fix misleading error messages and use the service-name constant in Lookup.The current messages say “publishing” while this block performs Lookup/Connect. Use MPI_SERVICE_NAME for consistency with Publish_name.
- try: - port_name = MPI.Lookup_name('my_port') - intercomm = MPI.COMM_WORLD.Connect(port_name) - except MPI.Exception as e: - print(f"Error publishing port name: {e}") - raise e - except Exception as e: - print(f"Unexpected error publishing port name: {e}") - raise e + try: + port_name = MPI.Lookup_name(MPI_SERVICE_NAME) + intercomm = MPI.COMM_WORLD.Connect(port_name) + except MPI.Exception as e: + print(f"Error during Lookup/Connect: {e}", flush=True) + raise + except Exception as e: + print(f"Unexpected error during Lookup/Connect: {e}", flush=True) + raise
233-235: Use bareraiseto preserve traceback context; include flush.Minor, but improves debuggability.
- except Exception as e: - print(f"Exception encountered: {e}", flush=True) - raise e + except Exception as e: + print(f"Exception encountered: {e}", flush=True) + raise
380-386: Improve MPI exception logging and ensure termination is robust.Print the exception details and flush. Also relies on intercomm being defined—apply the earlier predefinition.
- except MPI.Exception as e: - print(f"MPI Error") - raise e + except MPI.Exception as e: + print(f"MPI error: {e}", flush=True) + raiseAfter applying, please re-run the relevant tests to confirm no residual leaks or name-collision errors occur when running the whole test module.
481-486: Improve MPI exception logging and keep termination safe.Same as above: print the exception object for context and use bare raise.
- except MPI.Exception as e: - print(f"MPI Error") - raise e + except MPI.Exception as e: + print(f"MPI error: {e}", flush=True) + raise
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py(11 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+
Python indentation: 4 spaces, no tabs
Maintain module namespace in imports (from package.subpackage import foo; then use foo.SomeClass())
Python file names use snake_case
Python class names use PascalCase
Python functions/methods and local variables use snake_case; variables starting with a number get k_ prefix (e.g., k_99th_percentile)
Global variables use G_ prefixed UPPER_SNAKE_CASE (e.g., G_MY_GLOBAL)
Constants use UPPER_SNAKE_CASE in Python
Avoid shadowing variables from outer scopes in Python
Initialize all externally visible members of a Python class in init
Prefer docstrings for interfaces used outside a file; comments for local code
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes/variables inline with short docstrings
Avoid reflection when simple alternatives exist (e.g., prefer explicit parameters over dict(**locals()))
In try/except, catch the narrowest exceptions possible
For duck-typing with try/except, keep try body minimal and put logic in else
Files:
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py
**/*.{cpp,cxx,cc,cu,h,hpp,hxx,hh,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend NVIDIA copyright header (current year) to all source files
Files:
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (4)
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py (4)
186-186: LGTM: helper used for publishing.Using a helper here improves readability and centralizes error handling. No issues.
241-241: LGTM: explicit “waiting” log with flush improves CI readability.No action needed.
329-329: LGTM: consistent use of mpi_publish_name().No issues here.
431-431: LGTM: consistent use of mpi_publish_name().No issues here.
|
PR_Github #16081 [ run ] completed with state |
Signed-off-by: Patrice Castonguay <[email protected]>
Signed-off-by: Patrice Castonguay <[email protected]>
pcastonguay
force-pushed
the
disagg_test_mpi_init_fix
branch
from
29fc899 to
b445bbf
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #16200 [ run ] triggered by Bot |
|
Could someone from @NVIDIA/trt-llm-release-branch-approval please review? Thanks. |
|
/bot run --disable-fail-fast |
|
PR_Github #16463 [ run ] triggered by Bot |
|
PR_Github #16463 [ run ] completed with state |
…ng (#7139) Signed-off-by: Patrice Castonguay <[email protected]>
…ng (NVIDIA#7139) Signed-off-by: Patrice Castonguay <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…ng (NVIDIA#7139) Signed-off-by: Patrice Castonguay <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…ng (NVIDIA#7139) Signed-off-by: Patrice Castonguay <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…ng (NVIDIA#7139) Signed-off-by: Patrice Castonguay <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
…ng (NVIDIA#7139) Signed-off-by: Patrice Castonguay <[email protected]> Signed-off-by: Wangshanshan <[email protected]>
4 participants
Summary by CodeRabbit
Tests
Refactor
Chores
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.