Skip to content

[https://nvbugs/5453827][fix] Fix RPATH of th_common shared library to find pip-installed NCCL #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tongyuantongyu merged 3 commits into from
Aug 21, 2025
Merged

[https://nvbugs/5453827][fix] Fix RPATH of th_common shared library to find pip-installed NCCL #6984

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dda2d9
[https://nvbugs/5453827][fix] Fix RPATH of main shared library
tongyuantongyu Aug 18, 2025
2c3fe80
unwaive
tongyuantongyu Aug 19, 2025
c5fb6ca
Merge branch 'main' into ytong/fix_rpath_main_library
tongyuantongyu Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/tensorrt_llm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,7 @@ if(TARGET ${NIXL_WRAPPER_TARGET})
endif()

if(NOT WIN32)
set_target_properties(${SHARED_TARGET} PROPERTIES LINK_FLAGS
"-Wl,-rpath='$ORIGIN'")
set_target_properties(${SHARED_TARGET} PROPERTIES BUILD_RPATH "$ORIGIN")
endif()

if(BUILD_PYT)
Expand Down
6 changes: 3 additions & 3 deletions cpp/tensorrt_llm/thop/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ endif()

if(NOT WIN32)
set_target_properties(
th_common
PROPERTIES LINK_FLAGS
"-Wl,-rpath='$ORIGIN' ${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}")
th_common PROPERTIES BUILD_RPATH "$ORIGIN;$ORIGIN/../../nvidia/nccl/lib")
set_target_properties(
th_common PROPERTIES LINK_FLAGS "${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}")
else()
target_link_libraries(th_common PRIVATE context_attention_src)
endif()
5 changes: 0 additions & 5 deletions jenkins/L0_Test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,11 +2077,6 @@ def launchTestJobs(pipeline, testFilter, dockerNode=null)
checkPipStage = true
}

if (cpu_arch == AARCH64_TRIPLE && values[5] != DLFW_IMAGE) {
checkPipStage = false
echo "Skip pip install sanity check due to https://nvbugs/5453827"
}

if (checkPipStage) {
stage("Run LLMAPI tests") {
pipInstallSanitySpec = createKubernetesPodConfig(values[5], gpu_type, k8s_arch)
Expand Down