-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[nvbug/5410296][fix] Fix OOM in Llama 4 disagg-serve tests #6439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis change updates the configuration for a disaggregated serving accuracy test to explicitly set a maximum sequence length, removes a decorator from a disaggregated test, and deletes two skip entries from the test waiver list. No changes to logic, control flow, or public interfaces are present. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/bot run --add-multi-gpu-test |
PR_Github #13327 [ run ] triggered by Bot |
PR_Github #13327 [ run ] completed with state |
/bot run --add-multi-gpu-test |
PR_Github #13344 [ run ] triggered by Bot |
PR_Github #13344 [ run ] completed with state |
/bot run --add-multi-gpu-test |
PR_Github #13387 [ run ] triggered by Bot |
PR_Github #13387 [ run ] completed with state |
Signed-off-by: Bo Deng <[email protected]>
f53e20d
to
b1c01cd
Compare
/bot run --add-multi-gpu-test |
PR_Github #13448 [ run ] triggered by Bot |
PR_Github #13448 [ run ] completed with state |
Signed-off-by: Bo Deng <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
Signed-off-by: Bo Deng <[email protected]>
Summary by CodeRabbit
Description