tests: add TestNemotronH cuda graph tests #6390
Conversation
📝 Walkthrough""" WalkthroughThe changes introduce parameterization over the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tests/integration/defs/accuracy/test_llm_api_pytorch.py(1 hunks)tests/integration/test_lists/qa/benchmark_test_list.txt(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
**/*.py: Python code should conform to Python 3.8+.
Indent Python code with 4 spaces. Do not use tabs.
Always maintain the namespace when importing in Python, even if only one class or function from a module is used.
Python filenames should use snake_case (e.g., some_file.py).
Python classes should use PascalCase (e.g., class SomeClass).
Python functions and methods should use snake_case (e.g., def my_awesome_function():).
Python local variables should use snake_case. Prefix k for variable names that start with a number (e.g., k_99th_percentile).
Python global variables should use upper snake_case and prefix G (e.g., G_MY_GLOBAL).
Python constants should use upper snake_case (e.g., MY_CONSTANT).
Avoid shadowing variables declared in an outer scope in Python.
Initialize all externally visible members of a Python class in the constructor.
For interfaces that may be used outside a Python file, prefer docstrings over comments.
Comments in Python should be reserved for code within a function, or interfaces that are local to a file.
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx.
Attributes and variables in Python can be documented inline; attribute docstrings will be rendered under the docstring for the class.
Avoid using reflection in Python when functionality can be easily achieved without it.
When using try-except blocks in Python, limit the except to the smallest set of errors possible.
When using try-except blocks to handle multiple possible variable types in Python, keep the body of the try as small as possible, using the else block to implement the logic.
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.{cpp,h,hpp,cc,cxx,cu,py}
📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)
All TensorRT-LLM Open Source Software code should contain an NVIDIA copyright header that includes the current year. This includes .cpp, .h, .cu, .py, and any other source files which are compiled or interpreted.
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
🔇 Additional comments (3)
tests/integration/defs/accuracy/test_llm_api_pytorch.py (3)
1583-1584: LGTM! Parameterization implemented correctly.The
test_auto_dtypemethod has been properly parameterized with thecuda_graphflag, allowing the test to run with both CUDA graph enabled and disabled configurations.
1590-1590: LGTM! Conditional CUDA graph configuration implemented correctly.The conditional logic properly enables CUDA graph configuration when
cuda_graph=Trueand disables it whencuda_graph=False, following the same pattern used elsewhere in the codebase.
1597-1603: LGTM! Method parameterized correctly with appropriate hardware requirements.The
test_reasoning_fp8_prequantizedmethod has been properly parameterized with thecuda_graphflag using the same pattern astest_auto_dtype. The decorator change from@skip_pre_adato@skip_pre_hopperis appropriate for FP8 prequantized tests, which typically require Hopper architecture or newer for optimal performance.
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
from
394dcaf to
9e50514
Compare
coderabbitai
bot
requested review from
crazydemo,
pamelap-nvidia,
syuoni and
yilin-void
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
2 times, most recently
from
b08eda7 to
162176b
Compare
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
from
0a408ad to
98fcc4f
Compare
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
4 times, most recently
from
0b96cd4 to
596c055
Compare
|
/bot run |
|
PR_Github #13319 [ run ] triggered by Bot |
|
PR_Github #13319 [ run ] completed with state |
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
from
596c055 to
e78535c
Compare
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
from
e78535c to
ddca496
Compare
|
/bot run |
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
xinhe-nv
force-pushed
the
user/xinhe/NemotronH
branch
from
ddca496 to
885a7ad
Compare
|
PR_Github #13485 [ run ] triggered by Bot |
|
PR_Github #13485 [ run ] completed with state |
Signed-off-by: Xin He (SW-GPU) <[email protected]> Co-authored-by: Larry <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]> Co-authored-by: Larry <[email protected]>
addd nemotronH-8b, nemotronH-47b and nemotronH-56b cuda graph tests
test result with H100 https://prod.blsm.nvidia.com/swqa-tensorrt-qa-test/job/LLM_FUNCTION_TEST_DEBUG/1512/testReport/
Summary by CodeRabbit
Summary by CodeRabbit