[nvbug/5409414, 5355707] tests: adjust batchsize and decoding name #6292
Conversation
📝 Walkthrough""" WalkthroughThis change updates test configuration files and test scripts for Llama 3 models. It corrects the casing of decoding algorithm names in YAML references, adjusts batch size parameters in test cases, and adds or modifies test decorators and configurations to better control test execution based on hardware architecture. Changes
Sequence Diagram(s)sequenceDiagram
participant Tester
participant LLM
Note over Tester: test_ngram (PyTorch) flow
Tester->>LLM: Initialize with max_batch_size=16<br>and cuda_graph_config
LLM-->>Tester: Ready for test execution
Tester->>LLM: Run decoding test (NGramDecodingConfig, max_matching_ngram_size=2)
LLM-->>Tester: Return results
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run |
|
PR_Github #12692 [ run ] triggered by Bot |
|
PR_Github #12692 [ run ] completed with state |
|
/bot run |
|
PR_Github #12854 [ run ] triggered by Bot |
|
PR_Github #12854 [ run ] completed with state |
|
/bot run |
|
PR_Github #12856 [ run ] triggered by Bot |
|
PR_Github #12856 [ run ] completed with state |
crazydemo
force-pushed
the
fix_case
branch
2 times, most recently
from
8395cf4 to
fb9fc28
Compare
|
/bot run |
|
PR_Github #12874 [ run ] triggered by Bot |
|
PR_Github #12874 [ run ] completed with state |
|
/bot run |
|
PR_Github #12906 [ run ] triggered by Bot |
|
PR_Github #12906 [ run ] completed with state |
|
PR_Github #12926 [ run ] triggered by Bot |
|
PR_Github #12926 [ run ] completed with state |
|
/bot run |
|
PR_Github #12966 [ run ] triggered by Bot |
|
PR_Github #12966 [ run ] completed with state |
Signed-off-by: Ivy Zhang <[email protected]>
|
/bot run |
|
PR_Github #13130 [ run ] triggered by Bot |
|
PR_Github #13130 [ run ] completed with state |
…VIDIA#6292) Signed-off-by: Ivy Zhang <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
…VIDIA#6292) Signed-off-by: Ivy Zhang <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
…VIDIA#6292) Signed-off-by: Ivy Zhang <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
Summary by CodeRabbit
Tests
Style
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.