test: [CI] Add failed cases into waives.txt #6289
Conversation
WalkthroughSix new test cases are added to the skip list in Changes
Estimated code review effort1 (~2 minutes) Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
431-436: (Optional) Keep the waive list easier to scan by grouping new entries with their source file peers.
Consider inserting the threeaccuracy/test_llm_api_pytorch.pywaives right after the existing waives for that file (around line 388) and the threetest_e2e.pywaives near the othertest_e2e.pyblocks (~232, 391). This keeps related tests clustered and speeds up look-ups during triage.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt(1 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: yiqingy0
PR: NVIDIA/TensorRT-LLM#5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.076Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.
tests/integration/test_lists/waives.txt (1)
Learnt from: yiqingy0
PR: #5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.076Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: yiqingy0
PR: NVIDIA/TensorRT-LLM#5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.076Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.
tests/integration/test_lists/waives.txt (1)
Learnt from: yiqingy0
PR: #5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.076Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)
431-436: All six newly-waived tests conform to the expected “:: SKIP ()” format – LGTM.
No duplicate entries for these tests are present elsewhere in the list, and each line has the mandatory bug‐tracking URL.
Signed-off-by: xinhe-nv <[email protected]>
xinhe-nv
changed the title
|
/bot run |
xinhe-nv
deleted the
user/qa/post_update_waive_20250723_LLM_FUNCTION_TEST_DEBUG_1439
branch
|
PR_Github #12691 [ ] completed with state |
Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
waive failed cases.
Summary by CodeRabbit