Skip to content

Conversation

crazydemo
Copy link
Collaborator

@crazydemo crazydemo commented Jul 23, 2025

Summary by CodeRabbit

  • Tests
    • Simplified timeout handling in integration tests by removing custom timeout adjustment logic.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Copy link
Contributor

coderabbitai bot commented Jul 23, 2025

📝 Walkthrough

Walkthrough

The changes remove the get_pytest_timeout function from the test utility and simplify the call and check_output functions by eliminating pytest-specific timeout adjustments. Both functions now directly use the provided timeout parameter for subprocess management, streamlining the timeout logic.

Changes

File(s) Change Summary
tests/integration/defs/trt_test_alternative.py Removed get_pytest_timeout function; simplified call and check_output functions to use direct timeout checks without pytest-specific logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce32d7 and f850895.

📒 Files selected for processing (1)
  • tests/integration/defs/trt_test_alternative.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/integration/defs/trt_test_alternative.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@crazydemo crazydemo requested a review from EmmaQiaoCh July 23, 2025 08:41
@crazydemo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12683 [ run ] triggered by Bot

@crazydemo
Copy link
Collaborator Author

/bot kill

@crazydemo
Copy link
Collaborator Author

/bot run --stage-list "A10-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12697 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12683 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12697 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 930be2d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12698 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12698 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9446 (Partly Tested) completed with status: 'SUCCESS'

@crazydemo crazydemo force-pushed the remove_timeout_cmd_value branch from 930be2d to e34f81f Compare July 23, 2025 13:01
@crazydemo
Copy link
Collaborator Author

/bot run --stage-list "A10-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12712 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12712 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9459 (Partly Tested) completed with status: 'SUCCESS'

@crazydemo crazydemo force-pushed the remove_timeout_cmd_value branch from e34f81f to 8bdcd5c Compare July 23, 2025 14:58
@crazydemo
Copy link
Collaborator Author

/bot run --stage-list "A10-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12720 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12720 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9467 (Partly Tested) completed with status: 'FAILURE'

@crazydemo crazydemo force-pushed the remove_timeout_cmd_value branch from 8bdcd5c to a5ba6e0 Compare July 24, 2025 01:54
@crazydemo
Copy link
Collaborator Author

/bot run

@coderabbitai coderabbitai bot requested review from chzblych and niukuo July 24, 2025 01:55
@tensorrt-cicd
Copy link
Collaborator

PR_Github #12769 [ run ] triggered by Bot

@crazydemo
Copy link
Collaborator Author

timeout has been verified @EmmaQiaoCh

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12769 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9509 completed with status: 'FAILURE'

@crazydemo crazydemo force-pushed the remove_timeout_cmd_value branch 2 times, most recently from f626d30 to c3a969e Compare July 24, 2025 05:16
@crazydemo crazydemo force-pushed the remove_timeout_cmd_value branch from c3a969e to 1ce32d7 Compare July 24, 2025 05:16
@crazydemo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12802 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12802 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #9539 completed with status: 'FAILURE'

Signed-off-by: Ivy Zhang <[email protected]>
@crazydemo crazydemo force-pushed the remove_timeout_cmd_value branch from 1ce32d7 to f850895 Compare July 24, 2025 06:25
@crazydemo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12815 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12815 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9549 completed with status: 'SUCCESS'

@QiJune QiJune merged commit f290108 into NVIDIA:main Jul 24, 2025
3 checks passed
NVShreyas pushed a commit to NVShreyas/TensorRT-LLM that referenced this pull request Jul 28, 2025
Ransiki pushed a commit to Ransiki/TensorRT-LLM that referenced this pull request Jul 29, 2025
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants