infra: fix single-GPU stage failed will not raise error #6165
Conversation
WalkthroughThe update revises error handling in the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run --skip-test |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_MergeRequest.groovy(1 hunks)jenkins/L0_Test.groovy(1 hunks)
🔇 Additional comments (1)
jenkins/L0_MergeRequest.groovy (1)
988-988: LGTM! Improved error handling for single-GPU test failures.The direct error throwing approach correctly ensures that single-GPU test failures will properly propagate and fail the pipeline, which aligns with the PR objective of fixing error handling in the single-GPU stage.
|
PR_Github #12255 [ run ] triggered by Bot |
|
PR_Github #12255 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanrui/0718_fix_fail_fast_for_single_gpu
branch
from
9929214 to
92ba144
Compare
|
/bot run --skip-test |
|
PR_Github #12262 [ run ] triggered by Bot |
|
/bot run --skip-test |
|
PR_Github #12270 [ run ] triggered by Bot |
|
PR_Github #12262 [ run ] completed with state |
|
PR_Github #12270 [ run ] completed with state |
|
/bot run --skip-test --add-multi-gpu-test |
|
PR_Github #12278 [ run ] triggered by Bot |
|
PR_Github #12278 [ run ] completed with state |
ZhanruiSunCh
force-pushed
the
user/zhanrui/0718_fix_fail_fast_for_single_gpu
branch
2 times, most recently
from
cdc7423 to
13b887b
Compare
|
/bot run --skip-test |
|
PR_Github #12301 [ run ] triggered by Bot |
|
/bot run |
|
PR_Github #12310 [ run ] triggered by Bot |
|
PR_Github #12301 [ run ] completed with state |
|
PR_Github #12310 [ run ] completed with state |
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
This reverts commit d00628e. Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
ZhanruiSunCh
force-pushed
the
user/zhanrui/0718_fix_fail_fast_for_single_gpu
branch
from
13b887b to
042ed3b
Compare
|
/bot skip --comment "Only infra changed, infra test passed" |
|
PR_Github #12321 [ skip ] triggered by Bot |
|
PR_Github #12321 [ skip ] completed with state |
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.