Skip to content

Conversation

brb-nv
Copy link
Collaborator

@brb-nv brb-nv commented Jul 10, 2025

Description

Unfortunately, latest transformers update broke Gemma3 unit tests. There have been API changes as well as broad changes to HybridCache in transformers. So, I'm updating the tests to have as little customization as possible.

Also, adding existing tests to CI and new e2e test to CI.

$ python3 examples/llm-api/quickstart_multimodal.py --model_dir ../random/hf_models/gemma-3-27b-it/ --modality image --image_format pil --attention_backend FLASHINFER --disable_kv_cache_reuse

Test Coverage

- unittest/_torch/modeling -k "modeling_gemma3"
- test_e2e.py::test_ptp_quickstart_multimodal[gemma-3-27b-it-gemma/gemma-3-27b-it-image-False]

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@brb-nv brb-nv requested a review from a team as a code owner July 10, 2025 16:07
@brb-nv brb-nv requested review from mikeiovine and liji-nv July 10, 2025 16:07
@brb-nv brb-nv force-pushed the user/brb/gemma3-transformers-update branch 3 times, most recently from be1fd69 to ae3f33d Compare July 10, 2025 16:38
@brb-nv brb-nv changed the title test: Fix Gemma3 unit tests due to transformers upgarde test: Fix Gemma3 unit tests due to transformers upgrade Jul 10, 2025
@brb-nv brb-nv force-pushed the user/brb/gemma3-transformers-update branch from ae3f33d to ddc718b Compare July 10, 2025 16:41
@brb-nv brb-nv requested a review from 2ez4bz July 10, 2025 16:41
@brb-nv
Copy link
Collaborator Author

brb-nv commented Jul 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11564 [ run ] triggered by Bot

@2ez4bz
Copy link
Collaborator

2ez4bz commented Jul 10, 2025

LGTM.

@brb-nv brb-nv force-pushed the user/brb/gemma3-transformers-update branch from 4ca3604 to 6b15fa8 Compare July 10, 2025 18:24
@brb-nv
Copy link
Collaborator Author

brb-nv commented Jul 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11565 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11564 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11565 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8562 completed with status: 'FAILURE'

@brb-nv brb-nv force-pushed the user/brb/gemma3-transformers-update branch from 6b15fa8 to d1999c8 Compare July 10, 2025 20:46
@brb-nv
Copy link
Collaborator Author

brb-nv commented Jul 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11572 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11572 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8567 completed with status: 'SUCCESS'

@amukkara amukkara merged commit 0385f89 into NVIDIA:main Jul 11, 2025
3 checks passed
@brb-nv brb-nv deleted the user/brb/gemma3-transformers-update branch July 11, 2025 23:29
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants