[Bug] attention DP doesn't work with embedding TP #5642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Perkz Zheng <[email protected]>
PerkzZheng
force-pushed
the
user/perkzz/fix-attention-dp
branch
from
626a13e to
680565a
Compare
|
/bot run |
|
PR_Github #10486 [ run ] triggered by Bot |
|
PR_Github #10486 [ run ] completed with state |
byshiue
approved these changes
Jul 2, 2025
Shunkangz
pushed a commit
to Shunkangz/TensorRT-LLM
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 9, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Perkz Zheng <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Perkz Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedding TP should be disabled when the attention DP is used.