Skip to content

Conversation

tongyuantongyu
Copy link
Member

@tongyuantongyu tongyuantongyu commented Jun 25, 2025

Description

Reduce compile time and binary size by only compile for architectures each kernel designed for.

Notable extra changes:

  • Switch to CMake's CUDA_ARCHITECTURES support for convenient architecture configuration.
  • Compile for family conditional targets, to prepare for future architectures.
  • Switch to Ninja when building on CI for better job parallelization.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@tongyuantongyu tongyuantongyu force-pushed the ytong/build_targeted_arch branch 2 times, most recently from 794b310 to 346d037 Compare June 25, 2025 10:06
@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9880 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9880 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #7292 completed with status: 'FAILURE'

@tongyuantongyu tongyuantongyu force-pushed the ytong/build_targeted_arch branch 2 times, most recently from 44b3a58 to 6973199 Compare June 26, 2025 03:04
@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9952 [ run ] triggered by Bot

@tongyuantongyu tongyuantongyu force-pushed the ytong/build_targeted_arch branch from 6973199 to a0976ad Compare June 26, 2025 03:21
@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9958 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9952 [ run ] completed with state ABORTED

@tongyuantongyu tongyuantongyu force-pushed the ytong/build_targeted_arch branch 2 times, most recently from f61fc81 to 5d84733 Compare June 26, 2025 10:38
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9958 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #7348 completed with status: 'FAILURE'

@tongyuantongyu
Copy link
Member Author

/bot run --diaable-fail-fast

@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10061 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --diaable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10062 [ run ] triggered by Bot

@tongyuantongyu
Copy link
Member Author

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10094 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10062 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10094 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 5d84733

@tongyuantongyu tongyuantongyu force-pushed the ytong/build_targeted_arch branch 2 times, most recently from 2a5a99e to 722ac31 Compare June 27, 2025 03:33
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10265 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10282 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7601 completed with status: 'FAILURE'

@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10380 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10380 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7677 completed with status: 'FAILURE'

@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10415 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10415 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7702 completed with status: 'FAILURE'

@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10449 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10449 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #7731 completed with status: 'FAILURE'

@tongyuantongyu
Copy link
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10558 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10558 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7813 completed with status: 'SUCCESS'

Signed-off-by: Yuan Tong <[email protected]>
@tongyuantongyu
Copy link
Member Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10947 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10947 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #10558 for commit 757cdaa

@juney-nvidia juney-nvidia merged commit 32b244a into NVIDIA:main Jul 4, 2025
3 checks passed
@tongyuantongyu tongyuantongyu deleted the ytong/build_targeted_arch branch July 4, 2025 08:50
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants