[enhance] Add the ability to write a request timeline. #5258
Conversation
There was a problem hiding this comment.
The change LGTM overall. How about adding a test for this feature in case of any future regression? For instance, turn the flag on, run trtllm-bench with several samples, and check that the JSON file contains exactly the same number of records in the end.
Maybe off the topic, it might make sense to create a dedicated bench directory here to maintain the related tests.
FrankD412
force-pushed
the
fdinatale/trtllm-bench/request_timeline
branch
from
35ab9df to
61aff0c
Compare
FrankD412
force-pushed
the
fdinatale/trtllm-bench/request_timeline
branch
2 times, most recently
from
7bf730c to
e99e788
Compare
@Superjomn -- are you okay if this is merged in once it passes? We need to handle testing better overall, so I think we should make a plan to address that once some refactoring is done (I'm working on an intrusive refactor now). |
|
/bot run |
|
PR_Github #11174 [ run ] triggered by Bot |
|
PR_Github #11174 [ run ] completed with state |
Signed-off-by: Frank Di Natale <[email protected]>
FrankD412
force-pushed
the
fdinatale/trtllm-bench/request_timeline
branch
from
0e2771c to
d02fb06
Compare
|
/bot run |
|
PR_Github #11181 [ run ] triggered by Bot |
|
PR_Github #11181 [ run ] completed with state |
Signed-off-by: Frank <[email protected]>
|
/bot run |
|
/bot kill |
|
PR_Github #11567 [ kill ] triggered by Bot |
|
PR_Github #11567 [ kill ] completed with state |
|
PR_Github #11566 [ run ] triggered by Bot |
Signed-off-by: Frank Di Natale <[email protected]>
|
/bot run |
|
PR_Github #11568 [ run ] triggered by Bot |
|
PR_Github #11566 [ run ] completed with state |
|
PR_Github #11568 [ run ] completed with state |
|
/bot run |
|
PR_Github #11573 [ run ] triggered by Bot |
|
PR_Github #11573 [ run ] completed with state |
Signed-off-by: Frank Di Natale <[email protected]> Signed-off-by: Frank <[email protected]> Signed-off-by: Yuxin <[email protected]>
Description
When trying to debug issues related to functional issues, the JSON report out of the requests with their timestamps allows for more extensive data deep dive into the behavior the LLM API. The new JSON output allows for users to construct plots and perform other processing without needing
trtllm-benchto provide the functionality to do so.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.