Skip to content

Conversation

nv-yilinf
Copy link
Collaborator

[feat] Add EAGLE3 support for Qwen3

Description

TP8EP8 BS1 performance

===========================================================
= PERFORMANCE OVERVIEW 
===========================================================
Request Throughput (req/sec):                     0.1092
Total Output Throughput (tokens/sec):             212.1662
Total Token Throughput (tokens/sec):              333.2106
Total Latency (ms):                               293123.9179
Average request latency (ms):                     9159.9570
Per User Output Throughput [w/ ctx] (tps/user):   212.0583
Per GPU Output Throughput (tps/gpu):              26.5208
Average time-to-first-token [TTFT] (ms):          63.8031
Average time-per-output-token [TPOT] (ms):        4.6880
Per User Output Speed (tps/user):                 213.4385

AL over the first 32 queries in the AA dataset

===========================================================
= DECODING STATISTICS (Eagle)
===========================================================

-- Acceptance Rate Details --------------------------------


[AR] MINIMUM: 1.73
[AR] MAXIMUM: 1.89
[AR] AVERAGE: 1.81
[AR] P50    : 1.82
[AR] P90    : 1.89
[AR] P95    : 1.89
[AR] P99    : 1.89
===========================================================

Usage:
Add the following configs to extra-llm-api-config.yml

speculative_config:
    decoding_type: Eagle
    max_draft_len: 3
    pytorch_eagle_weights_path: /home/scratch.yeyu_hw/shared_files/Qwen3-235B-eagle3

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@nv-yilinf nv-yilinf requested a review from a team as a code owner June 13, 2025 16:18
@nv-yilinf nv-yilinf requested review from byshiue and yilin-void June 13, 2025 16:18
@nv-yilinf nv-yilinf force-pushed the add-eagle3-support-for-qwen3 branch from cfd884a to ece6cd2 Compare June 13, 2025 16:30
@nv-yilinf
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8841 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8841 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6428 completed with status: 'FAILURE'

@nv-yilinf
Copy link
Collaborator Author

/bot run --disable-fail-fast

1 similar comment
@nv-yilinf
Copy link
Collaborator Author

/bot run --disable-fail-fast

@nv-yilinf
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8851 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8851 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6438 completed with status: 'FAILURE'

@juney-nvidia juney-nvidia requested a review from mikeiovine June 14, 2025 03:14
@juney-nvidia
Copy link
Collaborator

@nv-yilinf
Copy link
Collaborator Author

/bot run --disable-fail-fast

@nv-yilinf
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8942 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8942 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6525 completed with status: 'FAILURE'

@byshiue byshiue force-pushed the add-eagle3-support-for-qwen3 branch from ece6cd2 to 5737157 Compare June 16, 2025 01:39
@byshiue
Copy link
Collaborator

byshiue commented Jun 16, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8954 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8954 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6534 completed with status: 'FAILURE'

@nv-yilinf
Copy link
Collaborator Author

/bot run --disable-fail-fast

1 similar comment
@nv-yilinf
Copy link
Collaborator Author

/bot run --disable-fail-fast

@nv-yilinf
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8966 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8966 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6544 completed with status: 'FAILURE'

@nv-yilinf
Copy link
Collaborator Author

/bot run

2 similar comments
@nv-yilinf
Copy link
Collaborator Author

/bot run

@nv-yilinf
Copy link
Collaborator Author

/bot run

@nv-yilinf
Copy link
Collaborator Author

/bot run

1 similar comment
@byshiue
Copy link
Collaborator

byshiue commented Jun 17, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9082 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9082 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6644 completed with status: 'FAILURE'

@byshiue byshiue force-pushed the add-eagle3-support-for-qwen3 branch from 5737157 to 4607ffc Compare June 17, 2025 05:20
@byshiue
Copy link
Collaborator

byshiue commented Jun 17, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9139 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9139 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6692 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Copy link
Collaborator

@byshiue byshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byshiue byshiue merged commit 498fadc into NVIDIA:main Jun 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants