[feat] Add progress bar to benchmark #5173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvzhihanj
requested review from
FrankD412 and
kaiyux
and removed request for
FrankD412
Signed-off-by: Rashid Kaleem <[email protected]>
arekay
force-pushed
the
arekay/tqdm_bar_benchmark
branch
from
df70ee9 to
4f43b92
Compare
FrankD412
approved these changes
Jun 17, 2025
|
/bot run |
|
@kaiyux can you help approve this PR? |
|
PR_Github #9931 [ run ] triggered by Bot |
|
PR_Github #9931 [ run ] completed with state |
|
/bot run |
|
/bot kill |
|
/bot run |
|
PR_Github #9963 [ run ] triggered by Bot |
|
PR_Github #9966 [ kill ] triggered by Bot |
|
PR_Github #9963 [ run ] completed with state |
|
PR_Github #9966 [ kill ] completed with state |
|
PR_Github #9967 [ run ] triggered by Bot |
|
PR_Github #9967 [ run ] completed with state |
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 9, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 10, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
dominicshanshan
pushed a commit
to dominicshanshan/TensorRT-LLM
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Rashid Kaleem <[email protected]> Co-authored-by: Zhihan Jiang <[email protected]> Co-authored-by: Frank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add progress bar to benchmark
Description
Adds a progress bar to track the number of requests executed via benchmark script. This is useful to gauge whether the benchmark is running or not without having per-iter output which can be too verbose for most users.