Skip to content

Conversation

ccs96307
Copy link
Contributor

@ccs96307 ccs96307 commented Jun 9, 2025

PR title

[#4974][fix] Fix thread leak in scaffolding unittest by explicitly shutting down ScaffoldingLlm

Description

There is a thread leak in tests/unittest/scaffolding/test_bench.py caused by a missing shutdown() call on ScaffoldingLlm-based workers.

This issue causes the threadleak hook to fail during test execution.

This PR adds an explicit .shutdown() to ensure proper resource cleanup and allow the unit test to pass.

Test Coverage

  • tests/unittest/scaffolding/test_bench.py
  • Verified that pytest now passes

GitHub Bot Help

/bot run

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@VALLIS-NERIA VALLIS-NERIA added the Community want to contribute PRs initiated from Community label Jun 9, 2025
@VALLIS-NERIA VALLIS-NERIA requested a review from WeiHaocheng June 11, 2025 06:28
@WeiHaocheng WeiHaocheng force-pushed the fix-scaffolding-unittest branch from 4243eb6 to c9b9fa4 Compare June 11, 2025 11:07
@WeiHaocheng
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8478 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8478 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6143 completed with status: 'SUCCESS'

@WeiHaocheng WeiHaocheng force-pushed the fix-scaffolding-unittest branch from 71c0992 to cf9282d Compare July 4, 2025 01:33
@WeiHaocheng WeiHaocheng enabled auto-merge (squash) July 4, 2025 01:33
@WeiHaocheng
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10890 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10890 [ reuse-pipeline ] completed with state SUCCESS
Can't reuse PR_Github #0 with status: UNKNOWN

@WeiHaocheng
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11773 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11773 [ reuse-pipeline ] completed with state SUCCESS
Can't reuse PR_Github #0 with status: UNKNOWN

@WeiHaocheng WeiHaocheng force-pushed the fix-scaffolding-unittest branch from ba6c04a to 6efee96 Compare July 14, 2025 08:37
@WeiHaocheng
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11788 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11788 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8734 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@WeiHaocheng WeiHaocheng merged commit dbf2918 into NVIDIA:main Jul 14, 2025
3 checks passed
@ccs96307 ccs96307 deleted the fix-scaffolding-unittest branch July 14, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community want to contribute PRs initiated from Community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants