Skip to content

Conversation

yiqingy0
Copy link
Collaborator

@yiqingy0 yiqingy0 commented Jun 6, 2025

Only run the triton_backend pre-merge tests if only triton relevant files are touched.

Triton relevant files:
tests/integration/defs/triton_server/
triton_backend/

Summary by CodeRabbit

  • Refactor
    • Generalized detection of file changes to identify if all changes belong exclusively to a single group ("PyTorch", "Triton", or "Docs"), enabling more flexible and accurate test filtering.
    • Consolidated and simplified handling of documentation-only changes under the new group-based logic.
    • Updated test stage selection to better align with the detected group of changed files, improving pipeline efficiency.

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9168 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9168 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6715 completed with status: 'ABORTED'

@yiqingy0
Copy link
Collaborator Author

/bot run

@yiqingy0 yiqingy0 changed the title [TRTLLM-5312] - Add triton tests if triton files are touched [TRTLLM-5312] - Add bot run rules for triton tests Jun 17, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9185 [ run ] triggered by Bot

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9314 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9314 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6836 completed with status: 'FAILURE'

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9349 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9349 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6862 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Copy link
Contributor

coderabbitai bot commented Jul 17, 2025

Walkthrough

The changes generalize the detection and handling of file change groups in the Jenkins pipeline scripts. The previous logic for identifying only PyTorch or Docs file changes is replaced with a unified mechanism that detects if all changed files belong exclusively to "PyTorch", "Triton", or "Docs" groups. Related flags, functions, and conditional logic are updated accordingly.

Changes

File(s) Change Summary
jenkins/L0_MergeRequest.groovy Renamed and generalized ONLY_PYTORCH_FILE_CHANGED to ONLY_ONE_GROUP_CHANGED (boolean→string), replaced detection functions, removed docs-specific logic, updated environment setup and SBSA test stage conditions.
jenkins/L0_Test.groovy Renamed and generalized test filter flag to ONLY_ONE_GROUP_CHANGED (boolean→string), removed docs-specific flag, consolidated and expanded test job filtering based on group, updated related conditional logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant JenkinsPipeline
    participant FileChangeDetector
    participant TestJobLauncher

    User->>JenkinsPipeline: Trigger pipeline with code changes
    JenkinsPipeline->>FileChangeDetector: Analyze changed files
    FileChangeDetector->>JenkinsPipeline: Return group ("PyTorch", "Triton", "Docs", or "")
    JenkinsPipeline->>TestJobLauncher: Launch jobs based on ONLY_ONE_GROUP_CHANGED
    alt ONLY_ONE_GROUP_CHANGED == "Docs"
        TestJobLauncher->>JenkinsPipeline: Run only Docs build stages
    else ONLY_ONE_GROUP_CHANGED == "PyTorch" or "Triton"
        TestJobLauncher->>JenkinsPipeline: Exclude unrelated backend stages
    else
        TestJobLauncher->>JenkinsPipeline: Run all relevant test stages
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • ZhanruiSunCh
  • chzblych

Poem

A hop and a skip through Jenkins code,
Now groups are detected, in one tidy mode.
PyTorch or Triton, or Docs if you please,
The pipeline now sorts them all with ease.
With logic refined and flags rearranged,
This bunny approves—how cleverly changed! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19a859b and c2267b7.

📒 Files selected for processing (2)
  • jenkins/L0_MergeRequest.groovy (5 hunks)
  • jenkins/L0_Test.groovy (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • jenkins/L0_MergeRequest.groovy
  • jenkins/L0_Test.groovy
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

yiqingy0 added 5 commits July 23, 2025 03:01
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #12696 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12696 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9445 completed with status: 'SUCCESS'

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12774 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12774 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9514 completed with status: 'SUCCESS'

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12785 [ run ] triggered by Bot

Signed-off-by: Yiqing Yan <[email protected]>
@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12826 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12785 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12826 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9560 completed with status: 'FAILURE'

@yiqingy0
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12868 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12868 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9591 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@yiqingy0
Copy link
Collaborator Author

LGTM, I suggest to simulate some common scenarios for testing.

Run the test for "only docs change", "only triton files change" and "only pytorch files change".

@yiqingy0 yiqingy0 merged commit d974198 into NVIDIA:main Jul 25, 2025
3 checks passed
@yiqingy0 yiqingy0 deleted the triton_tests branch July 25, 2025 02:31
NVShreyas pushed a commit to NVShreyas/TensorRT-LLM that referenced this pull request Jul 28, 2025
Ransiki pushed a commit to Ransiki/TensorRT-LLM that referenced this pull request Jul 29, 2025
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants