-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[TRTLLM-5312] - Add bot run rules for triton tests #4988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/bot run |
PR_Github #9168 [ run ] triggered by Bot |
PR_Github #9168 [ run ] completed with state |
/bot run |
PR_Github #9185 [ run ] triggered by Bot |
/bot run |
PR_Github #9314 [ run ] triggered by Bot |
PR_Github #9314 [ run ] completed with state |
/bot run |
PR_Github #9349 [ run ] triggered by Bot |
PR_Github #9349 [ run ] completed with state |
WalkthroughThe changes generalize the detection and handling of file change groups in the Jenkins pipeline scripts. The previous logic for identifying only PyTorch or Docs file changes is replaced with a unified mechanism that detects if all changed files belong exclusively to "PyTorch", "Triton", or "Docs" groups. Related flags, functions, and conditional logic are updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant JenkinsPipeline
participant FileChangeDetector
participant TestJobLauncher
User->>JenkinsPipeline: Trigger pipeline with code changes
JenkinsPipeline->>FileChangeDetector: Analyze changed files
FileChangeDetector->>JenkinsPipeline: Return group ("PyTorch", "Triton", "Docs", or "")
JenkinsPipeline->>TestJobLauncher: Launch jobs based on ONLY_ONE_GROUP_CHANGED
alt ONLY_ONE_GROUP_CHANGED == "Docs"
TestJobLauncher->>JenkinsPipeline: Run only Docs build stages
else ONLY_ONE_GROUP_CHANGED == "PyTorch" or "Triton"
TestJobLauncher->>JenkinsPipeline: Exclude unrelated backend stages
else
TestJobLauncher->>JenkinsPipeline: Run all relevant test stages
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
PR_Github #12696 [ run ] triggered by Bot |
PR_Github #12696 [ run ] completed with state |
/bot run |
PR_Github #12774 [ run ] triggered by Bot |
PR_Github #12774 [ run ] completed with state |
/bot run |
PR_Github #12785 [ run ] triggered by Bot |
Signed-off-by: Yiqing Yan <[email protected]>
/bot run |
PR_Github #12826 [ run ] triggered by Bot |
PR_Github #12785 [ run ] completed with state |
PR_Github #12826 [ run ] completed with state |
/bot run |
PR_Github #12868 [ run ] triggered by Bot |
PR_Github #12868 [ run ] completed with state |
Run the test for "only docs change", "only triton files change" and "only pytorch files change". |
Signed-off-by: Yiqing Yan <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>
Only run the triton_backend pre-merge tests if only triton relevant files are touched.
Triton relevant files:
tests/integration/defs/triton_server/
triton_backend/
Summary by CodeRabbit