Exposes base OptionsContext class in the API
#396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavm-nvidia
requested review from
christopherbate and
shelkesagar29
as code owners
pranavm-nvidia
commented
Nov 20, 2024
pranavm-nvidia
commented
Nov 20, 2024
mlir-tensorrt/compiler/include/mlir-tensorrt/Compiler/StableHloToExecutable.h
Outdated
Show resolved
Hide resolved
pranavm-nvidia
commented
Nov 20, 2024
pranavm-nvidia
force-pushed
the
common-options
branch
2 times, most recently
from
ba839d4 to
cd2393b
Compare
christopherbate
approved these changes
Nov 22, 2024
Collaborator
christopherbate
left a comment
christopherbate
left a comment
There was a problem hiding this comment.
Overall it looks good. Noted in the comments a couple things that need to be tweaked before merging, but once that's done and it passes CI, then it should be good to merge.
One thing to note is that we currently have the CI building static libs. Since you're introducing static registration mechanisms, you definitely want to check the CMake build with -DBUILD_SHARED_LIBS=ON as well. Let me know if any questions.
mlir-tensorrt/compiler/include/mlir-tensorrt-c/Compiler/Compiler.h
Outdated
Show resolved
Hide resolved
mlir-tensorrt/compiler/include/mlir-tensorrt/Compiler/StableHloToExecutable.h
Outdated
Show resolved
Hide resolved
mlir-tensorrt/compiler/include/mlir-tensorrt-c/Compiler/Compiler.h
Outdated
Show resolved
Hide resolved
pranavm-nvidia
force-pushed
the
common-options
branch
from
cd2393b to
0ddb923
Compare
pranavm-nvidia
commented
Nov 25, 2024
pranavm-nvidia
force-pushed
the
common-options
branch
2 times, most recently
from
64979d3 to
b7ddf31
Compare
christopherbate
approved these changes
Nov 27, 2024
Collaborator
christopherbate
left a comment
christopherbate
left a comment
There was a problem hiding this comment.
LGTM except for some additional minor comments
mlir-tensorrt/compiler/include/mlir-tensorrt/Compiler/OptionsRegistry.h
Outdated
Show resolved
Hide resolved
mlir-tensorrt/compiler/include/mlir-tensorrt/Compiler/OptionsRegistry.h
Outdated
Show resolved
Hide resolved
pranavm-nvidia
force-pushed
the
common-options
branch
from
b7ddf31 to
ce836cd
Compare
In order to support more than just the StableHloToExecutable pipeline, we need to be able to create different option types from the API. This commit exposes the base `OptionsContext` class in the Python API and includes a mechanism for child classes to register themselves with the client, allowing them to be created through a common API.
pranavm-nvidia
force-pushed
the
common-options
branch
from
ce836cd to
8bb2572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support more than just the StableHloToExecutable pipeline, we need to be able to create different option types from the API. This commit exposes the base
OptionsContextclass in the Python API and includes a mechanism for child classes to register themselves with the client, allowing them to be created through a common API.