fix(cli): add missing Copilot variant to CliProviderType enum#713
Open
johntmyers wants to merge 1 commit intomainfrom
Open
fix(cli): add missing Copilot variant to CliProviderType enum#713johntmyers wants to merge 1 commit intomainfrom
johntmyers wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copilotvariant to theCliProviderTypeenum and itsas_str()match arm, fixing--provider copilotCLI argument parsing.cli_provider_types_match_registry) that assertsCliProviderTypevariants matchProviderRegistry::known_types(), preventing this class of drift in the future.Related Issue
Closes #707
Changes
crates/openshell-cli/src/main.rs: AddedCopilotvariant toCliProviderTypeenum and"copilot"arm toas_str().crates/openshell-cli/src/main.rs(tests): Addedcli_provider_types_match_registrytest that iterates allCliProviderTypevariants viaValueEnum::value_variants()and compares againstProviderRegistry::known_types().Testing
cargo test -p openshell-cli --bin openshell cli_provider_types_match_registrypasses.cargo fmt --checkandcargo clippyclean on changed file.Checklist