Update Progress After Streaming Disconnect for Node and Backend Events #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethany-nv
had a problem deploying
to
internal-ci
GitHub Actions
Error
ethany-nv
temporarily deployed
to
internal-ci
GitHub Actions
Inactive
xutongNV
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the watch stream disconnects because there are no node events for a long period of time, the listener does not write progress. This updates the logic so that even when it disconnects due to any issue or the fact that there are no events within the request_timeout period, it should still write progress to prevent liveness probe from erroneously killing the listener.
Issue - None
Checklist