#137 - UI: use the absolute path to support different hostnames #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the UI to use the absolute path for logs, spec, etc. instead of the fully-qualified path when displayed in iframes. By doing so, the browser uses the domain of the page and the UI can fully function regardless of the
service_base_url, which may be another domain.For deployments like our brev launchable, this means that the
service_base_urlcan behttp://quick-start.osmobut still use the brev secure link for the UI.Issue #137
Testing
curl -O https://raw.githubusercontent.com/NVIDIA/OSMO/refs/heads/main/deployments/brev/setup.shosmoinstall to use the newly-built private images8000Checklist