Skip to content

Add Weave-integrated feedback buttons to agent response messages #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thepatrickchin wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Weave-integrated feedback buttons to agent response messages #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c27e6bc
Forward Weave-Call-Id header in non-streaming chat responses
thepatrickchin Nov 12, 2025
ab24ceb
Include weave call IDs for each response message in conversation history
thepatrickchin Nov 12, 2025
6a03d39
Add feedback buttons to Weave-traced response messages
thepatrickchin Nov 12, 2025
a47709c
Add feedback buttons to Weave-traced response messages in websocket mode
thepatrickchin Nov 12, 2025
38f5c6c
Add feedback buttons to Weave-traced response messages from streaming…
thepatrickchin Nov 12, 2025
33318a4
Update tests for Weave Call ID extraction
thepatrickchin Nov 12, 2025
561a71c
Update documentation for feedback buttons
thepatrickchin Nov 13, 2025
c9ae8b0
Add toast message for feedback button interactions
thepatrickchin Nov 13, 2025
0aeaa9e
Rename and generalize weave_call_id to observability_trace_id
thepatrickchin Nov 14, 2025
55301aa
Read observability trace IDs from separate SSE and websocket messages
thepatrickchin Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions __tests__/api/routes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,9 @@ describe('Proxy Request Transformers and Response Processors', () => {
const mockBackendRes = {
ok: true,
text: jest.fn().mockResolvedValue('{"value":"Test response"}'),
headers: {
get: jest.fn().mockReturnValue(null),
},
};

const mockRes = {
Expand Down Expand Up @@ -509,13 +512,40 @@ describe('Proxy Request Transformers and Response Processors', () => {
expect(mockRes.writeHead).toHaveBeenCalledWith(500, expect.any(Object));
expect(mockRes.end).toHaveBeenCalledWith('Internal Server Error');
});

it('should forward observability-trace-id header from backend', async () => {
const mockBackendRes = {
ok: true,
text: jest.fn().mockResolvedValue('{"value":"Test response"}'),
headers: {
get: jest.fn((name) => {
if (name === 'observability-trace-id') return 'trace-header-123';
return null;
}),
},
};

const mockRes = {
writeHead: jest.fn(),
end: jest.fn(),
};

await processGenerate(mockBackendRes, mockRes);

expect(mockRes.writeHead).toHaveBeenCalledWith(200, expect.objectContaining({
'Observability-Trace-Id': 'trace-header-123',
}));
});
});

describe('processChat', () => {
it('should process JSON response', async () => {
const mockBackendRes = {
ok: true,
text: jest.fn().mockResolvedValue('{"choices":[{"message":{"content":"Chat response"}}]}'),
headers: {
get: jest.fn().mockReturnValue(null),
},
};

const mockRes = {
Expand Down Expand Up @@ -547,6 +577,30 @@ describe('Proxy Request Transformers and Response Processors', () => {
expect(mockRes.writeHead).toHaveBeenCalledWith(400, expect.any(Object));
expect(mockRes.end).toHaveBeenCalledWith('Bad Request');
});

it('should forward observability-trace-id header from backend', async () => {
const mockBackendRes = {
ok: true,
text: jest.fn().mockResolvedValue('{"choices":[{"message":{"content":"Chat response"}}]}'),
headers: {
get: jest.fn((name) => {
if (name === 'observability-trace-id') return 'trace-chat-456';
return null;
}),
},
};

const mockRes = {
writeHead: jest.fn(),
end: jest.fn(),
};

await processChat(mockBackendRes, mockRes);

expect(mockRes.writeHead).toHaveBeenCalledWith(200, expect.objectContaining({
'Observability-Trace-Id': 'trace-chat-456',
}));
});
});

describe('processChatStream', () => {
Expand Down Expand Up @@ -609,6 +663,25 @@ describe('Proxy Request Transformers and Response Processors', () => {
expect(mockRes.write).toHaveBeenCalledWith(expect.stringContaining('Test Step'));
});

it('should process observability_trace lines separately', async () => {
const mockBackendRes = createStreamingResponse([
'data: {"choices":[{"delta":{"content":"Response"}}]}\n',
'observability_trace: {"observability_trace_id":"trace-abc-123"}\n',
]);

const mockRes = {
writeHead: jest.fn(),
write: jest.fn(),
end: jest.fn(),
};

await processChatStream(mockBackendRes, mockRes);

// Should write both content and trace ID tag
expect(mockRes.write).toHaveBeenCalledWith('Response');
expect(mockRes.write).toHaveBeenCalledWith(expect.stringContaining('<observabilitytraceid>trace-abc-123</observabilitytraceid>'));
});

it('should handle non-ok response', async () => {
const mockBackendRes = {
ok: false,
Expand Down Expand Up @@ -688,6 +761,24 @@ describe('Proxy Request Transformers and Response Processors', () => {
expect(mockRes.write).toHaveBeenCalledWith(expect.stringContaining('Generation Step'));
});

it('should process observability_trace lines separately', async () => {
const mockBackendRes = createStreamingResponse([
'data: {"value":"Generated text"}\n',
'observability_trace: {"observability_trace_id":"trace-def-456"}\n',
]);

const mockRes = {
writeHead: jest.fn(),
write: jest.fn(),
end: jest.fn(),
};

await processGenerateStream(mockBackendRes, mockRes);

// Should process trace ID separately from content
expect(mockRes.write).toHaveBeenCalledWith(expect.stringContaining('<observabilitytraceid>trace-def-456</observabilitytraceid>'));
});

it('should handle non-ok response', async () => {
const mockBackendRes = {
ok: false,
Expand Down
Loading