Skip to content

fix: node drainer enqueuing duplicate elements [WIP] #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XRFXLP wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: node drainer enqueuing duplicate elements [WIP] #644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52cb532
fix: node drainer enqueuing duplicate elements
XRFXLP Dec 23, 2025
50732b5
Merge branch 'main' into fix-nd-oom
XRFXLP Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions node-drainer/pkg/reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,18 @@ func (r *Reconciler) setInitialStatusAndEnqueue(ctx context.Context, document ma

r.logStatusUpdateResult(result, nodeName, documentID)

// Enqueue to the queue manager
return r.queueManager.EnqueueEventGeneric(ctx, nodeName, document, r.databaseClient)
// Only enqueue if we successfully claimed the event (ModifiedCount > 0)
// This prevents duplicate enqueueing when change stream replays events or
// cold start reprocesses events that are already InProgress
if result.ModifiedCount > 0 {
return r.queueManager.EnqueueEventGeneric(ctx, nodeName, document, r.databaseClient)
}

slog.Debug("Event already in progress, skipping enqueue",
"node", nodeName,
"documentID", fmt.Sprintf("%v", documentID))

return nil
}

// logStatusUpdateResult logs the result of the status update
Expand Down
Loading