Skip to content

Make Minitron search space choices configurable for smaller test models #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kevalmorabia97 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make Minitron search space choices configurable for smaller test models #709

kevalmorabia97 wants to merge 5 commits into from
+68 −38

Conversation

@kevalmorabia97
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 commented Dec 18, 2025 •
edited
Loading

  • Test update, no code change.
  • In follow-up PR, we will change search space divisor to 256 so search space is smaller for auto-pruning to be faster

@kevalmorabia97 kevalmorabia97 requested a review from a team as a code owner December 18, 2025 18:21
@codecov
Copy link

codecov bot commented Dec 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.67%. Comparing base (b286165) to head (8130249).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   74.73%   74.67%   -0.07%     
==========================================
  Files         192      192              
  Lines       18870    18909      +39     
==========================================
+ Hits        14103    14120      +17     
- Misses       4767     4789      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 enabled auto-merge (squash) December 19, 2025 05:48
AAnoosheh
AAnoosheh reviewed Dec 19, 2025
View reviewed changes
modelopt/torch/prune/plugins/mcore_minitron.py


# Allow overriding the SS channel divisor for unit testing on smaller models
MINITRON_SS_CHANNEL_DIVISOR = int(os.getenv("MINITRON_SS_CHANNEL_DIVISOR", 64))
Copy link
Contributor

@AAnoosheh AAnoosheh Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not just pass in custom config during tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AAnoosheh AAnoosheh AAnoosheh left review comments

@ChenhanYu ChenhanYu Awaiting requested review from ChenhanYu

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevalmorabia97 @AAnoosheh