Skip to content

Conversation

@aartbik
Copy link
Collaborator

@aartbik aartbik commented Jun 4, 2025

No description provided.

@aartbik aartbik requested review from cliffburdick and Copilot June 4, 2025 18:48
@cliffburdick
Copy link
Collaborator

/build

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the level-order indexing for DIA storage in sparse operations, updates the DIA tensor constructor to match the new axis ordering, and adds a simple example printout.

  • Change CRDData and crdSize calls from axis 1 to axis 0 in solve and matvec implementations
  • Swap the order of offset and empty storage in make_tensor_dia and adjust pos initialization
  • Add a printf in the example to show direct element access from a DIA tensor

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
include/matx/transforms/solve/solve_cusparse.h Use CRDData(0)/crdSize(0) for diagonals instead of axis 1
include/matx/transforms/matmul/matvec_cusparse.h Mirror the same axis-0 fix for matvec; adjust CRDData and crdSize
include/matx/core/make_sparse_tensor.h Update comment, use off.Size(0) for pos, and swap CRD storage order
examples/sparse_tensor.cu Add printf to demonstrate reading a single DIA element
Comments suppressed due to low confidence (1)

include/matx/core/make_sparse_tensor.h:225

  • The comment uses #diags as a placeholder; update it to refer explicitly to off.Size(0) to avoid confusion.
  // compression should set up pos[0] = {0, #diags}. This is done

@aartbik aartbik merged commit 19c5bbd into NVIDIA:main Jun 4, 2025
1 check passed
@aartbik aartbik deleted the bok branch June 4, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants