Generalize DIA to DIA-I and DIA-J #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIA-J is most common but DIA-I is used by cuSPARSE legacy
Collaborator
|
/build |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR generalizes the DIA sparse matrix format to support both DIA-I and DIA-J variants, addressing compatibility with legacy cuSPARSE usage. Key changes include:
- Conditional kernel invocation updated in matvec_cusparse.h to select between DIAI and DIAJ kernels.
- New kernel implementations added in matvec.cuh with revisions to loop variable naming.
- Updated type definitions and tensor creation APIs in sparse_tensor_format.h and make_sparse_tensor.h, as well as corresponding changes in example usage.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| include/matx/transforms/matmul/matvec_cusparse.h | Updated kernel dispatch to select DIAI or DIAJ based on format check. |
| include/matx/kernels/matvec.cuh | Added diai_spmv_kernel and diaj_spmv_kernel with loop variable inconsistency. |
| include/matx/core/sparse_tensor_format.h | Introduced new DIAI/DIAJ type definitions and related format changes. |
| include/matx/core/make_sparse_tensor.h | Modified DIA tensor construction to choose between DIAI and DIAJ. |
| examples/sparse_tensor.cu | Updated example calls to reflect the new DIAI/J APIs. |
cliffburdick
approved these changes
May 30, 2025
Collaborator
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIA-J is most common but DIA-I is used by cuSPARSE legacy