Skip to content

Cleanup cmake usage when MatX is a dependent project #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cliffburdick merged 1 commit into from
Jan 16, 2025
Merged

Cleanup cmake usage when MatX is a dependent project #827

cliffburdick merged 1 commit into from
Jan 16, 2025

Conversation

@tmartin-gh
Copy link
Collaborator

@tmartin-gh tmartin-gh commented Jan 16, 2025

Couple minor items:

  1. Use FetchContent_Declare's SOURCE_DIR feature instead of directly setting a variable
  2. Use CMAKE_CURRENT_SOURCE_DIR relative path to test vectors, allowing MatX tests to be built when MatX is not the top level project

@tmartin-gh
Copy link
Collaborator Author

tmartin-gh commented Jan 16, 2025

/build

@cliffburdick cliffburdick merged commit 39ba917 into NVIDIA:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cliffburdick cliffburdick cliffburdick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmartin-gh @cliffburdick