Skip to content

Host Solver workspace query fix #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cliffburdick merged 2 commits into from
Aug 26, 2024
Merged

Host Solver workspace query fix #733

cliffburdick merged 2 commits into from
Aug 26, 2024

Conversation

@aayushg55
Copy link
Contributor

@aayushg55 aayushg55 commented Aug 22, 2024

  • Fix for LAPACK bug causing incorrect workspace size calculations for single-precision routines at large matrix sizes due to float-to-int conversions (only those that may need O(n^2) space like Eig and SVD are affected)
  • Removed caching in Host LU and Cholesky since no workspace is required

Misc: Renamed Host solver cache types to be lowercase for consistency

@aayushg55 aayushg55 requested a review from cliffburdick August 22, 2024 23:24
@cliffburdick
Copy link
Collaborator

cliffburdick commented Aug 22, 2024

/build

@cliffburdick cliffburdick merged commit baae78f into main Aug 26, 2024
@cliffburdick cliffburdick deleted the host_workspace branch August 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cliffburdick cliffburdick cliffburdick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aayushg55 @cliffburdick