Skip to content

Conversation

@cliffburdick
Copy link
Collaborator

@cliffburdick cliffburdick commented Jun 7, 2024

Fixes #646

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@raplonu
Copy link
Contributor

raplonu commented Jun 7, 2024

@cliffburdick thanks for looking at this issue.

Another solution could be do the following:

if (NOT CMAKE_BUILD_TYPE OR "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")

"${CMAKE_BUILD_TYPE}" will still be considered as a STRING even if empty.

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

5 similar comments
@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@coveralls
Copy link

Coverage Status

coverage: 93.603%. remained the same
when pulling 05db76c on ninja_cmake
into 1816b44 on main.

@cliffburdick cliffburdick merged commit e8f96bf into main Jun 7, 2024
@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick cliffburdick deleted the ninja_cmake branch June 7, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Configuration error using Ninja Multi-Config.

4 participants