Skip to content

Conversation

@ZJUGuoShuai
Copy link
Contributor

MatX sets -Werror in its main CMakeLists.txt:

set(WARN_FLAGS ${WARN_FLAGS} $<$<COMPILE_LANGUAGE:CUDA>:-Werror all-warnings>)
set(WARN_FLAGS ${WARN_FLAGS} $<$<COMPILE_LANGUAGE:CXX>:-Werror>)

Thus all warnings are treated as errors, which may lead to compilation failures.

In this PR, I fixed some errors (warnings, e.g. comparing signed/unsigned numbers) and now all unit tests compiles fine.

@cliffburdick
Copy link
Collaborator

/blossom-ci

@cliffburdick
Copy link
Collaborator

Thanks @AtomicVar!

@cliffburdick cliffburdick merged commit 3cb7c0a into NVIDIA:main Oct 16, 2023
@ZJUGuoShuai ZJUGuoShuai deleted the fix-test-errors branch January 16, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants