Adding initial polyphase resampler transform #437
Conversation
|
/blossom-ci |
|
Thrilled to see this PR, @tbensonatl. I originally posted about the polyphase channelizer, asking if it matched the cusignal version, before realizing this PR is about the resampler. My bad, but I'm still equally happy to see MatX include these core signal processing functions. |
cliffburdick
left a comment
cliffburdick
left a comment
There was a problem hiding this comment.
Nice work! Can you add documentation in docs_input as well? At a minimum it can be added to the API section, but if you want to make a new rst file with some text about usage, limitations, etc, that would be useful.
@awthomp Right, this is a polyphase resampler, but there is also interest in polyphase filters and channelizers. I assume you are talking about this cusignal function: https://docs.rapids.ai/api/cusignal/stable/api/#module-cusignal.filtering.channelize_poly ? I will take a look at that in the future. |
tbensonatl
force-pushed
the
resample_poly_1d_initial
branch
from
572bcb3 to
8d950d7
Compare
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
Initial version of a polyphase resampler. This version is focused primarily on correctness and a simple interface (i.e. no temporary work buffers).